Repository navigation
Bank surface source particles in all active cycles - #2592
Merged
Merged
Conversation
Prevent repeated thread_safe_append on surface source bank, update test
gridley
approved these changes
Jul 11, 2023
gridley
left a comment
gridley
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Just some optional suggestions.
| if (surf->surf_source_ && simulation::current_batch == settings::n_batches) { | ||
| if (surf->surf_source_ && simulation::current_batch > settings::n_inactive && | ||
| !simulation::surf_source_bank.full()) { | ||
| SourceSite site; |
Contributor
There was a problem hiding this comment.
It would be nice if we had Particle::to_source_site, since this pattern is probably used elsewhere. Again, not necessary.
Contributor
Author
There was a problem hiding this comment.
Good suggestion! I'll look into doing this on a separate PR
paulromano
enabled auto-merge (squash)
July 14, 2023 18:32
apingegno
pushed a commit
to apingegno/openmc
that referenced
this pull request
May 7, 2026
Co-authored-by: Jose Ignacio Marquez Damian <22483345+marquezj@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces #2505. @marquezj I tried to make a quick fix on your branch for the failing test (had to do with how many MPI processes were used) but ended up screwing things up. So sorry about that!!
Checklist
[ ] I have made corresponding changes to the documentation (if applicable)