Repository navigation
Remove use of mgxs module in MicroXS.from_model - #2572
Merged
Merged
Conversation
yardasol
reviewed
Jun 22, 2023
yardasol
left a comment
yardasol
left a comment
Contributor
There was a problem hiding this comment.
Hi @paulromano,
Do you think at some point in the future it would make sense to use the mgxs module if/when we add support for multiple energy groups in MicroXS?
Even if this is the case, I like that we no longer have a bunch of duplicate flux tallies! I'll approve once the tests past!
paulromano
force-pushed
the
microxs-no-mgxs
branch
from
June 22, 2023 18:59
8c0b4c5 to
4ed3cc6
Compare
Co-authored-by: Olek <45364492+yardasol@users.noreply.github.com>
Contributor
Author
|
@yardasol Even when we add support for multiple energy groups, I don't think |
apingegno
pushed a commit
to apingegno/openmc
that referenced
this pull request
May 7, 2026
Co-authored-by: Olek <45364492+yardasol@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, the
MicroXS.from_modelclassmethod has adilute_initialargument that implements behavior similar to what has now been removed in #2568. In order to remove this fromMicroXS, the first step is to get rid of its current reliance onopenmc.mgxsto calculate microscopic cross sections (having had a look atmgxs, there's not a clear path in my mind for utilizing themultiply_densityoption there). This PR simply replaces the use ofmgxswith manual creation of tallies that setmultiply_density = False. Thedilute_initialargument is preserved in this PR but will be removed in a future PR.Checklist