Skip to content

allowing stepresult to save to a path - #2567

Merged
paulromano merged 3 commits into
openmc-dev:developfrom
shimwell:adding_path_option_to_StepResult
Jun 21, 2023
Merged

paulromano merged 3 commits into
openmc-dev:developfrom
shimwell:adding_path_option_to_StepResult

Conversation

@shimwell

Copy link
Copy Markdown
Member

Description

This PR adds a path argument to the StepResult.save() method which allows the user to specify a path of the depltion result. The default is still depletion_result.h5.

Fixes # (issue)
Partly fixes user request https://openmc.discourse.group/t/output-folder-path-for-integrator-integrate/3089/2

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

@shimwell
shimwell requested a review from drewejohnson as a code owner June 16, 2023 16:47

@paulromano paulromano left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small requests on this:

Comment thread openmc/deplete/stepresult.py Outdated
Comment thread openmc/deplete/stepresult.py Outdated
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
@paulromano
paulromano enabled auto-merge (squash) June 21, 2023 11:45
@paulromano
paulromano merged commit 2536cae into openmc-dev:develop Jun 21, 2023
apingegno pushed a commit to apingegno/openmc that referenced this pull request May 7, 2026
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants