Repository navigation
Use multiply_density in depletion reaction rate helper classes - #2559
Merged
Merged
Conversation
drewejohnson
approved these changes
Jun 12, 2023
drewejohnson
left a comment
drewejohnson
left a comment
Contributor
There was a problem hiding this comment.
Just want to make sure I follow the logic
- new tally feature used in depletion does not scale reaction rate tallies by the number density of the target nuclide.
- Depletion backend doesn't really need reaction rates with units atoms/barn-cm, but we do need them to be absolute
- So we need to re-incorporate the volume of the tallied domain (materials) into the tallies
That all checks out to me. I'm happy to merge this through as is, comments are non-blocking
Co-authored-by: Andrew Johnson <drewejohnson@users.noreply.github.com>
Contributor
Author
|
@drewejohnson Any further comments on this or do you think it's good to merge? btw, thanks for chiming in! Wasn't sure if you were paying attention to the day-to-day OpenMC happenings anymore 😄 |
Contributor
|
Thanks @paulromano! I see things on occasion and try to help where I can! Not so much day to day, maybe month to month 😅 |
4 tasks done
apingegno
pushed a commit
to apingegno/openmc
that referenced
this pull request
May 7, 2026
…nmc-dev#2559) Co-authored-by: Andrew Johnson <drewejohnson@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow on to #2539 and updates the depletion system in OpenMC to utilize the new
multiply_densityoption. Since depletion only requires microscopic reaction rates, there's no need to have the tally system multiply by atom density only to divide it out later. With changes here, we now avoid that.These changes will allow us to get rid of
dilute_initialaltogether. In fact, I already have that working on a branch but will save it for a separate PR because it does result in test changes. The changes in this PR require no updates to test results.