Repository navigation
Add support for curvilinear elements when exporting cylindrical and spherical meshes to VTK - #2533
Merged
Merged
Conversation
Contributor
|
@pshriwise Looks like there are some conflicts on this branch that need to be resolved |
Contributor
Author
Thanks! Just took care of those. |
paulromano
requested changes
Jun 14, 2023
paulromano
left a comment
paulromano
left a comment
Contributor
There was a problem hiding this comment.
Nicely done with this! I only have a few minor comments and suggestions:
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
…make shapes in properties consistent
paulromano
approved these changes
Jun 16, 2023
apingegno
pushed a commit
to apingegno/openmc
that referenced
this pull request
May 7, 2026
…pherical meshes to VTK (openmc-dev#2533) Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset provides the option to export cylindrical and spherical meshes (with optional datasets) to VTK with
vtkQuadraticHexelements. While the equations of the element surface don't match the cylindrical/spherical boundaries exactly, they can make a big difference in visualization for coarse meshes.Below is a visualization of a cylindrical mesh with some dummy data applied. On the left is the linear element representation. The right shows the mesh exported with the curvilinear element option.
This capability won't have any effect on how
Regular/RectilinearMesh's are exported.