Repository navigation
Fix potential out-of-bounds access in TimeFilter - #2532
Merged
Merged
Conversation
HunterBelanger
left a comment
HunterBelanger
left a comment
Contributor
There was a problem hiding this comment.
Other than my one minor comment, it looks like this should fix the problem. Thanks @paulromano for submitting this fix.
HunterBelanger
approved these changes
Jun 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@HunterBelanger pointed out to me that there is a potential for an out-of-bounds error due to the lack of a check in
TimeFilter::get_all_bins. Namely, for collision estimator/surface tallies, we don't check that the ending time of a particle's track is within the time bin range. This PR simply adds that check.