Repository navigation
Auto pixel calc for universe plot - #2513
Merged
paulromano merged 6 commits intoMay 23, 2023
Merged
Conversation
paulromano
requested changes
May 22, 2023
paulromano
left a comment
paulromano
left a comment
Contributor
There was a problem hiding this comment.
One small change and then this is good to go!
shimwell
commented
May 23, 2023
paulromano
reviewed
May 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've just been using the recently upgraded universe.plot and really liking all the automation.
I am thinking it could be even more convenient if we calculate the pixels in each basis direction for the user.
For long thin plots with a high aspect ratio I found myself manually calculating the aspect ratio and change the default pixels from (200, 200) to something that shared the pixels more evenly across the plot.
I thought it might be worth allowing the user to put in a single int and in this case treating this input as a total number of pixels sharing the pixels across the axis proportionally to their width. This allow easier scaling of resolution without the user having to know the aspect ratio of their geometry.