Skip to content

Provide alternative batch estimation message - #2479

Merged
paulromano merged 2 commits into
openmc-dev:developfrom
pshriwise:improve-trigger-msg
Apr 18, 2023
Merged

paulromano merged 2 commits into
openmc-dev:developfrom
pshriwise:improve-trigger-msg

Conversation

@pshriwise

Copy link
Copy Markdown
Contributor

Provides an alternative error message if the ratio between the tally uncertainty and threshold uncertainty is INFTY.

Resolves #2477.

@shimwell shimwell self-assigned this Apr 15, 2023
@shimwell

Copy link
Copy Markdown
Member

Thanks Patrick, that was very quick, I'm keen to give this a go once I get back to my desktop on Monday.

@shimwell shimwell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Patrick this does close out that issue nicely. Thanks for clearing that up

@shimwell

Copy link
Copy Markdown
Member

If there are no objections as this is a relatively small PR, I shall add that merging in < 24 hours tag and aim to merge this in tomorrow

@shimwell shimwell added the Merging Soon PR will be merged in < 24 hrs if no further comments are made. label Apr 17, 2023

@paulromano paulromano left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need clang-format on this one

@pshriwise

Copy link
Copy Markdown
Contributor Author

Need clang-format on this one

Oops, sure does. Fresh OS install got me.

@paulromano paulromano left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@paulromano
paulromano merged commit 1afe429 into openmc-dev:develop Apr 18, 2023
apingegno pushed a commit to apingegno/openmc that referenced this pull request May 7, 2026
Provide alternative batch estimation message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merging Soon PR will be merged in < 24 hrs if no further comments are made.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tally tigger estimating negative number of batches till completion

3 participants