Repository navigation
A few improvements related to the Model class - #2465
Merged
Merged
Conversation
jtramm
approved these changes
Apr 12, 2023
jtramm
left a comment
jtramm
left a comment
Contributor
There was a problem hiding this comment.
This seems like a good way of fixing the issue. The keyword arguments when exporting to XML seem useful as well.
LGTM!
apingegno
pushed a commit
to apingegno/openmc
that referenced
this pull request
May 7, 2026
A few improvements related to the Model class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes a few small improvements related to the
openmc.Modelclass:mode.run, you can now pass keyword arguments on toexport_to_xmlorexport_to_model_xml, which importantly allows you to callmodel.run(remove_surfs=True), which was not possible before.<plots>are present in a model.xml file, OpenMC will now look for a plots.xml file. This closesplot_inlinefunction doesn't work well when using model.xml #2446.