Repository navigation
Raise error when mesh is flat - #2363
Merged
Merged
Conversation
shimwell
reviewed
Jan 27, 2023
eepeterson
reviewed
Jan 27, 2023
paulromano
requested changes
Jan 28, 2023
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
paulromano
approved these changes
Jan 28, 2023
shimwell
reviewed
Feb 1, 2023
Member
|
As this quite a small PR, mainly tests and double approved I think we can go ahead and merge this one. |
apingegno
pushed a commit
to apingegno/openmc
that referenced
this pull request
May 7, 2026
…_mesh Raise error when mesh is flat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of our students ran into an weird hanging behaviour. We realised it is a case of #2070.
We also realised I offered to work on a fix for this exact same issue....... but never did. So here it is!
This PR adds a test for the
RegularMeshcorners to check if the mesh is flat (infinitely thin). If so, aValueErroris raised.