Repository navigation
Make sure Chain.reduce preserves decay source information - #2283
Merged
eepeterson merged 1 commit intoOct 29, 2022
Merged
Conversation
eepeterson
approved these changes
Oct 29, 2022
eepeterson
left a comment
eepeterson
left a comment
Contributor
There was a problem hiding this comment.
simple enough thanks for the fix @paulromano!
apingegno
pushed a commit
to apingegno/openmc
that referenced
this pull request
May 7, 2026
…es-bugfix Make sure Chain.reduce preserves decay source information
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just noticed that if you have a
deplete.Chainwith information in the newsourcesattribute, that information is lost if you callChain.reduce(...). This PR fixes that and updates a test with a corresponding check on the sources after callingreduce.