Repository navigation
Fix reading reference direction from XML for angular distributions - #2204
Merged
Merged
Conversation
eepeterson
approved these changes
Sep 6, 2022
eepeterson
left a comment
eepeterson
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the fix @paulromano!
apingegno
pushed a commit
to apingegno/openmc
that referenced
this pull request
May 7, 2026
Fix reading reference direction from XML for angular distributions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recently discovered that the
reference_uvwattribute set on angular distributions (openmc.stats.PolarAzimuthalandopenmc.stats.Monodirectional) doesn't roundtrip correctly. This PR fixes that and adds a unit test that would have caught this in the first place.