Repository navigation
Disable GNU extensions for CMake targets - #2072
Merged
paulromano merged 1 commit intoMay 25, 2022
Merged
Conversation
paulromano
changed the title
shimwell
self-requested a review
May 23, 2022 21:53
shimwell
approved these changes
May 24, 2022
Member
There was a problem hiding this comment.
I've tested this with the same system that was previously failing to compile openmc and can confirm that this now compiles 🎉
Link to issue https://openmc.discourse.group/t/compile-error-no-match-for-operator/2065/4
apingegno
pushed a commit
to apingegno/openmc
that referenced
this pull request
May 7, 2026
…sions Disable GNU extensions for CMake targets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A user ran into a build issue using gcc 7 building the latest branch of OpenMC. I was able to trace this down to the fact that CMake will by default turn on GNU compiler extensions (
-std=gnu14instead of-std=c++14), which apparently can cause a conflict for complex literals. The solution is to simply turn off GNU extensions using theCXX_EXTENSIONStarget property.