Skip to content

Fix IO format documentation for surf_source_read/write - #2048

Merged
paulromano merged 1 commit into
openmc-dev:developfrom
paulromano:surfsrc-docfix
May 2, 2022
Merged

paulromano merged 1 commit into
openmc-dev:developfrom
paulromano:surfsrc-docfix

Conversation

@paulromano

Copy link
Copy Markdown
Contributor

A user noted that the I/O format documentation for surface source read/write information is not correct. This PR fixes that.

@pshriwise pshriwise left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another clear improvement from @paulromano. Thanks!

@pshriwise

Copy link
Copy Markdown
Contributor

Seems like we're going to have to adjust our settings for PR checks since #2010 isn't going to allow any of the required jobs to run.

@paulromano
paulromano merged commit bb642a7 into openmc-dev:develop May 2, 2022
@paulromano

Copy link
Copy Markdown
Contributor Author

@pshriwise That's unfortunate. As far as I can tell, it doesn't look like there's a clean way for us to ignore paths when running CI checks and get around the required status checks at the same time. For this PR, I merged using an override as an administrator, but I'd rather not do that each time we have a simple PR like this.

@paulromano
paulromano deleted the surfsrc-docfix branch May 2, 2022 11:57
@pshriwise

Copy link
Copy Markdown
Contributor

Agreed. Thanks for taking care of that! I'll make an issue so we don't lose track of it.

apingegno pushed a commit to apingegno/openmc that referenced this pull request May 7, 2026
Fix IO format documentation for surf_source_read/write
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants