Skip to content

Allow control of C++ standard. - #2040

Merged
paulromano merged 2 commits into
openmc-dev:developfrom
aprilnovak:cxx_17
Apr 26, 2022
Merged

paulromano merged 2 commits into
openmc-dev:developfrom
aprilnovak:cxx_17

Conversation

@aprilnovak

Copy link
Copy Markdown
Contributor

Use cxx_std_14 feature to allow another application (in this case, Cardinal) to upgrade the C++ version.

Closes #2039

@aprilnovak

Copy link
Copy Markdown
Contributor Author

fyi @loganharbour @GiudGiud

@loganharbour

Copy link
Copy Markdown
Contributor

👍🏼 probably remove the now redundant comment about "another way"?

@paulromano paulromano left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay for more CMake improvements -- thanks @aprilnovak! Will merge at the end of the day tomorrow if there are no other comments.

@paulromano

Copy link
Copy Markdown
Contributor

@aprilnovak I just noticed that tests/regression_tests/external_moab/test.py is also using the old CXX_STANDARD approach — would you mind updating that for consistency?

@aprilnovak

Copy link
Copy Markdown
Contributor Author

Sure, I think I got it - I don't have OpenMC built with MOAB so was not able to test it though, just FYI.

@paulromano
paulromano merged commit 996ada5 into openmc-dev:develop Apr 26, 2022
apingegno pushed a commit to apingegno/openmc that referenced this pull request May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade or control C++ standard

3 participants