fix: use UUID when no toolcallId

vincentkoc · Feb 5, 2026 · Feb 5, 2026 · Feb 5, 2026 · Feb 5, 2026 · Feb 5, 2026
commit 9192c4042baa2711892410f3c35937d55a4a309e
diff --git a/src/agents/pi-embedded-runner/compact.ts b/src/agents/pi-embedded-runner/compact.ts
@@ -437,7 +437,8 @@ export async function compactEmbeddedPiSessionDirect(
         if (limited.length > 0) {
           session.agent.replaceMessages(limited);
         }
-        const hookSessionKey = params.sessionKey ?? `session:${params.sessionId}`;
+        const missingSessionKey = !params.sessionKey || !params.sessionKey.trim();
+        const hookSessionKey = params.sessionKey?.trim() || `compact:${params.sessionId}`;
         const hookRunner = getGlobalHookRunner();
         const messageCountOriginal = originalMessages.length;
         const messageCountBefore = session.messages.length;
@@ -464,6 +465,7 @@ export async function compactEmbeddedPiSessionDirect(
         try {
           const hookEvent = createInternalHookEvent("session", "compact:before", hookSessionKey, {
             sessionId: params.sessionId,
+            missingSessionKey,
             messageCount: messageCountBefore,
             tokenCount: tokenCountBefore,
             messageCountOriginal,
@@ -516,6 +518,7 @@ export async function compactEmbeddedPiSessionDirect(
         try {
           const hookEvent = createInternalHookEvent("session", "compact:after", hookSessionKey, {
             sessionId: params.sessionId,
+            missingSessionKey,
             messageCount: messageCountAfter,
             tokenCount: tokensAfter,
             compactedCount,

diff --git a/src/agents/pi-embedded-runner/run.ts b/src/agents/pi-embedded-runner/run.ts
@@ -1,3 +1,4 @@
+import { randomUUID } from "node:crypto";
 import fs from "node:fs/promises";
 import type { ThinkLevel } from "../../auto-reply/thinking.js";
 import type { RunEmbeddedPiAgentParams } from "./run/params.js";
@@ -690,7 +691,7 @@ export async function runEmbeddedPiAgent(
               pendingToolCalls: attempt.clientToolCall
                 ? [
                     {
-                      id: attempt.clientToolCall.toolCallId || `call_${Date.now()}`,
+                      id: attempt.clientToolCall.toolCallId || `call_${randomUUID()}`,
                       name: attempt.clientToolCall.name,
                       arguments: JSON.stringify(attempt.clientToolCall.params),
                     },