Repository navigation
Ignore ripgrep configuration when expanding sandbox deny globs - #51527
Merged
copyberry[bot] merged 1 commit intoOct 7, 2026
Conversation
## Why User ripgrep configuration can suppress the file list used to construct Linux sandbox deny masks. For example, `--quiet` in `RIPGREP_CONFIG_PATH` can leave files matching deny globs unmasked. ## What changed Pass `--no-config` to the ripgrep invocation that expands denied-file globs. ## Testing Extend the multiple-denied-files regression test with a ripgrep configuration containing `--quiet`, checking that denied files remain unreadable and unwritable while allowed files remain accessible. Skip the ripgrep-specific case when no protected `rg` executable is available. GitOrigin-RevId: 06a6e27e0edec92e79e99af5144b57f86079953f
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/06a6e27e0edec92e79e99af5144b57f86079953f
branch
from
October 7, 2026 00:51
90138a6 to
ac9b5b8
Compare
Contributor
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/06a6e27e0edec92e79e99af5144b57f86079953f
branch
October 7, 2026 00:51
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore ripgrep configuration when expanding sandbox deny globs
Why
User ripgrep configuration can suppress the file list used to construct Linux sandbox deny masks. For example,
--quietinRIPGREP_CONFIG_PATHcan leave files matching deny globs unmasked.What changed
Pass
--no-configto the ripgrep invocation that expands denied-file globs.Testing
Extend the multiple-denied-files regression test with a ripgrep configuration containing
--quiet, checking that denied files remain unreadable and unwritable while allowed files remain accessible. Skip the ripgrep-specific case when no protectedrgexecutable is available.