Skip to content

Honor server reasoning summary defaults in new TUI threads - #50811

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/c60e33d077298d7a89d6b95f94b1292c175d6c77
Oct 4, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/c60e33d077298d7a89d6b95f94b1292c175d6c77

Conversation

@copyberry

@copyberry copyberry Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Honor server reasoning summary defaults in new TUI threads

Why

New embedded TUI threads forced reasoning summaries off when no summary was explicitly configured, overriding the model's default. Client settings could also override the destination server's reasoning summary configuration.

What changed

Use the same launch override handling for embedded and remote thread starts so server configuration and model defaults determine reasoning summaries. Forward explicit profile and command-line choices for model_reasoning_summary and features.concurrent_reasoning_summaries, preserving both enabled and disabled values.

Testing

Extend coverage for model defaults reaching Responses requests, concurrent summary delivery, direct startup, and replacement sessions with profile and command-line overrides.

## Why

New embedded TUI threads forced reasoning summaries off when no summary was explicitly configured, overriding the model's default. Client settings could also override the destination server's reasoning summary configuration.

## What changed

Use the same launch override handling for embedded and remote thread starts so server configuration and model defaults determine reasoning summaries. Forward explicit profile and command-line choices for `model_reasoning_summary` and `features.concurrent_reasoning_summaries`, preserving both enabled and disabled values.

## Testing

Extend coverage for model defaults reaching Responses requests, concurrent summary delivery, direct startup, and replacement sessions with profile and command-line overrides.

GitOrigin-RevId: c60e33d077298d7a89d6b95f94b1292c175d6c77
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/c60e33d077298d7a89d6b95f94b1292c175d6c77 branch from 786ae84 to afb436d Compare October 4, 2026 07:12
@copyberry
copyberry Bot merged commit afb436d into main Oct 4, 2026
5 of 8 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/c60e33d077298d7a89d6b95f94b1292c175d6c77 branch October 4, 2026 07:12
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 4, 2026
@yfyau
yfyau deployed to issue-triage October 4, 2026 07:21 — with GitHub Actions Active
@yfyau
yfyau deployed to issue-triage October 4, 2026 07:21 — with GitHub Actions Active
@yfyau
yfyau deployed to issue-triage October 4, 2026 07:21 — with GitHub Actions Active
@yfyau
yfyau deployed to issue-triage October 4, 2026 07:23 — with GitHub Actions Active
@chenyang-zz
chenyang-zz deployed to issue-triage October 4, 2026 07:28 — with GitHub Actions Active
@chenyang-zz
chenyang-zz deployed to issue-triage October 4, 2026 07:28 — with GitHub Actions Active
@chenyang-zz
chenyang-zz deployed to issue-triage October 4, 2026 07:28 — with GitHub Actions Active
@nazemes
nazemes deployed to issue-triage October 4, 2026 07:29 — with GitHub Actions Active
@nazemes
nazemes deployed to issue-triage October 4, 2026 07:29 — with GitHub Actions Active
@nazemes
nazemes deployed to issue-triage October 4, 2026 07:29 — with GitHub Actions Active
@charlesverge
charlesverge deployed to issue-triage October 4, 2026 07:31 — with GitHub Actions Active
@charlesverge
charlesverge deployed to issue-triage October 4, 2026 07:31 — with GitHub Actions Active
@charlesverge
charlesverge deployed to issue-triage October 4, 2026 07:31 — with GitHub Actions Active
@charlesverge
charlesverge deployed to issue-triage October 4, 2026 07:31 — with GitHub Actions Active
@catInMud
catInMud deployed to issue-triage October 4, 2026 07:38 — with GitHub Actions Active
@catInMud
catInMud deployed to issue-triage October 4, 2026 07:38 — with GitHub Actions Active
@catInMud
catInMud deployed to issue-triage October 4, 2026 07:38 — with GitHub Actions Active
@catInMud
catInMud deployed to issue-triage October 4, 2026 07:39 — with GitHub Actions Active
@Polygons1
Polygons1 deployed to issue-triage October 4, 2026 08:15 — with GitHub Actions Active
@Polygons1
Polygons1 deployed to issue-triage October 4, 2026 08:15 — with GitHub Actions Active
@Polygons1
Polygons1 deployed to issue-triage October 4, 2026 08:16 — with GitHub Actions Active
@solar555
solar555 deployed to issue-triage October 4, 2026 08:28 — with GitHub Actions Active
@solar555
solar555 deployed to issue-triage October 4, 2026 08:28 — with GitHub Actions Active
@solar555
solar555 deployed to issue-triage October 4, 2026 08:28 — with GitHub Actions Active
@sixblade325
sixblade325 deployed to issue-triage October 4, 2026 08:46 — with GitHub Actions Active
@sixblade325
sixblade325 deployed to issue-triage October 4, 2026 08:46 — with GitHub Actions Active
@sixblade325
sixblade325 deployed to issue-triage October 4, 2026 08:46 — with GitHub Actions Active
@danielcwm
danielcwm deployed to issue-triage October 4, 2026 08:51 — with GitHub Actions Active
@danielcwm
danielcwm deployed to issue-triage October 4, 2026 08:51 — with GitHub Actions Active
@danielcwm
danielcwm deployed to issue-triage October 4, 2026 08:51 — with GitHub Actions Active
@poroburu
poroburu deployed to issue-triage October 4, 2026 08:55 — with GitHub Actions Active
@poroburu
poroburu deployed to issue-triage October 4, 2026 08:55 — with GitHub Actions Active
@poroburu
poroburu deployed to issue-triage October 4, 2026 08:55 — with GitHub Actions Active
@poroburu
poroburu deployed to issue-triage October 4, 2026 08:56 — with GitHub Actions Active
@seanyi0104
seanyi0104 deployed to issue-triage October 4, 2026 09:00 — with GitHub Actions Active
@seanyi0104
seanyi0104 deployed to issue-triage October 4, 2026 09:00 — with GitHub Actions Active
@seanyi0104
seanyi0104 deployed to issue-triage October 4, 2026 09:00 — with GitHub Actions Active
@darkneo29
darkneo29 deployed to issue-triage October 4, 2026 09:30 — with GitHub Actions Active
@darkneo29
darkneo29 deployed to issue-triage October 4, 2026 09:30 — with GitHub Actions Active
@darkneo29
darkneo29 deployed to issue-triage October 4, 2026 09:30 — with GitHub Actions Active

This branch was successfully deployed

1 active deployment
issue-triage — afb436df Deployed Oct 4, 2026 by KES777 via Identify potential duplicates (open issues fallback) #51746
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.