Repository navigation
Preserve Windows environment variables for remote MCP servers - #50129
Merged
copyberry[bot] merged 1 commit intoOct 2, 2026
Conversation
## Why When Codex runs on Unix and launches a stdio MCP server on a Windows executor, explicit remote environment variables activate an allowlist based on Unix defaults. This can filter out Windows runtime and temporary-directory variables. ## What changed Include `SYSTEMROOT`, `TEMP`, and `TMP` in the remote environment allowlist whenever explicit remote variables are requested. ## Testing Extend the environment-filtering test to verify that `SystemRoot`, `TEMP`, and `TMP` survive alongside requested variables while unrequested secrets remain excluded. GitOrigin-RevId: 059c9e23833be66aaf5b65ba5f95013f94f0f792
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/059c9e23833be66aaf5b65ba5f95013f94f0f792
branch
from
October 2, 2026 00:46
04ec418 to
7d3e696
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/059c9e23833be66aaf5b65ba5f95013f94f0f792
branch
October 2, 2026 00:46
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve Windows environment variables for remote MCP servers
Why
When Codex runs on Unix and launches a stdio MCP server on a Windows executor, explicit remote environment variables activate an allowlist based on Unix defaults. This can filter out Windows runtime and temporary-directory variables.
What changed
Include
SYSTEMROOT,TEMP, andTMPin the remote environment allowlist whenever explicit remote variables are requested.Testing
Extend the environment-filtering test to verify that
SystemRoot,TEMP, andTMPsurvive alongside requested variables while unrequested secrets remain excluded.