[opentelemetry-collector]: add Gateway API HTTPRoute support - #2246
TylerHelmuth merged 6 commits into
Conversation
|
|
24560e3 to
488612e
Compare
|
Friendly ping — this has been open for about a week. CLA is signed and CI is green. Happy to address any feedback whenever a maintainer has a moment to take a look. Thanks! |
Assisted-by: Claude Opus 4.8
488612e to
b10906c
Compare
|
Good idea. A passthrough The one bit I'd keep is defaulting the backendRef to the collector service, so users don't have to hand-write the generated service name and port (that's the main thing the current template does for them). So: render |
|
I missed that you're setting a default backend. In that case managing it like you have it is best. |
|
Thanks for confirming the approach — I kept the default backendRef behavior as you blessed. The |
…ctor/add-httproute # Conflicts: # charts/opentelemetry-collector/Chart.yaml
Assisted-by: Claude Opus 4.8
2 participants
Adds optional Gateway API
HTTPRoutesupport to theopentelemetry-collectorchart, as an alternative toIngressfor exposing the collector's HTTP-based receivers.The new
httprouteblock is disabled by default, so existing users are unaffected. It mirrors the existingingressconventions (labels, namespace,tpl-ed annotations) and exposes the standardHTTPRoutefields:enabled(defaultfalse)apiVersion(defaults togateway.networking.k8s.io/v1)annotations,parentRefs,hostnamesrules—matches+backendRefs(+ optionalfilters);backendRefs[].namedefaults to the collector service when omitted, matching the ingress backend conventionvalues.schema.jsonis extended with the matchinghttprouteschema (the chart enforcesadditionalProperties: false). Version bumped0.158.0->0.159.0and rendered examples regenerated.Validated locally:
helm lintandct lint --charts charts/opentelemetry-collector(allci/*value sets)values.schema.jsonrejects unknown keys underhttproutehelm templatefor: disabled (no output), enabled withparentRefs/hostnames/rules,backendRefsname auto-defaulting, andapiVersionoverridehttproute.enabled: trueis intentionally not added toci/because the collector test job's kind cluster does not install the Gateway API CRDs (only the operator test job does), soct installwould fail to create the resource. The disabled default keeps lint coverage.