Conversation
g-logunov
force-pushed
the
feature/fix-nested-nullable-unions-upstream
branch
from
September 27, 2026 18:35
7c1bc35 to
e869693
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2565.
Nested nullable unions lose their JSON methods and accessors during generation, causing JSON round trips to replace the payload with
{}.Preserve
UnionElementsandDiscriminatorin the sharedcollapseNullableUnionhelper so generated types retain their JSON methods, union accessors, and discriminator helpers.Regression coverage includes client/server round-trip matrix cases under schema-merging-behavior v1, v2, and v3, plus nullable-schema tests for nested
anyOf/oneOf, null values, and discriminator accessors. The matrix cases fail against current main and pass with the fix.Validation:
make tidy,make generate,make test, andmake lintpassed.