Skip to content

fix: clean up and test parameter binding #2307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mromaszewicz merged 6 commits into from
Apr 20, 2026
Merged

fix: clean up and test parameter binding #2307

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a369da5
fix: clean up and test parameter binding
mromaszewicz Mar 27, 2026
57c5f3c
Merge remote-tracking branch 'upstream/main' into feat/param-cleanup
mromaszewicz Apr 8, 2026
1fb0889
Update runtime and unstub tests
mromaszewicz Apr 8, 2026
17acd40
Update all sub-modules runtime version
mromaszewicz Apr 8, 2026
4eff71a
MeMerge remote-tracking branch 'origin/main' into feat/param-cleanup
mromaszewicz Apr 12, 2026
ae4a9c4
run go mod tidy in echo v5
mromaszewicz Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update runtime and unstub tests 
Runtime 1.4.0 allows us to run almost all parameter tests.
  • Loading branch information
@mromaszewicz
mromaszewicz committed Apr 8, 2026
commit 1fb0889c758da7c1cc2aea06a2bcec1bcc92b780
15 changes: 13 additions & 2 deletions examples/petstore-expanded/stdhttp/api/petstore.gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion internal/test/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ require (
github.com/labstack/echo/v4 v4.15.1
github.com/oapi-codegen/nullable v1.1.0
github.com/oapi-codegen/oapi-codegen/v2 v2.0.0-00010101000000-000000000000
github.com/oapi-codegen/runtime v1.3.1
github.com/oapi-codegen/runtime v1.4.0
github.com/oapi-codegen/testutil v1.1.0
github.com/stretchr/testify v1.11.1
gopkg.in/yaml.v2 v2.4.0
Expand Down
4 changes: 2 additions & 2 deletions internal/test/go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,8 +180,8 @@ github.com/nxadm/tail v1.4.11 h1:8feyoE3OzPrcshW5/MJ4sGESc5cqmGkGCWlco4l0bqY=
github.com/nxadm/tail v1.4.11/go.mod h1:OTaG3NK980DZzxbRq6lEuzgU+mug70nY11sMd4JXXHc=
github.com/oapi-codegen/nullable v1.1.0 h1:eAh8JVc5430VtYVnq00Hrbpag9PFRGWLjxR1/3KntMs=
github.com/oapi-codegen/nullable v1.1.0/go.mod h1:KUZ3vUzkmEKY90ksAmit2+5juDIhIZhfDl+0PwOQlFY=
github.com/oapi-codegen/runtime v1.3.1 h1:RgDY6J4OGQLbRXhG/Xpt3vSVqYpHQS7hN4m85+5xB9g=
github.com/oapi-codegen/runtime v1.3.1/go.mod h1:kOdeacKy7t40Rclb1je37ZLFboFxh+YLy0zaPCMibPY=
github.com/oapi-codegen/runtime v1.4.0 h1:KLOSFOp7UzkbS7Cs1ms6NBEKYr0WmH2wZG0KKbd2er4=
github.com/oapi-codegen/runtime v1.4.0/go.mod h1:5sw5fxCDmnOzKNYmkVNF8d34kyUeejJEY8HNT2WaPec=
github.com/oapi-codegen/testutil v1.1.0 h1:EufqpNg43acR3qzr3ObhXmWg3Sl2kwtRnUN5GYY4d5g=
github.com/oapi-codegen/testutil v1.1.0/go.mod h1:ttCaYbHvJtHuiyeBF0tPIX+4uhEPTeizXKx28okijLw=
github.com/oasdiff/yaml v0.0.0-20260313112342-a3ea61cb4d4c h1:7ACFcSaQsrWtrH4WHHfUqE1C+f8r2uv8KGaW0jTNjus=
Expand Down
36 changes: 19 additions & 17 deletions internal/test/issues/issue-2232/issue2232.gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions internal/test/parameters/echo/parameters_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,15 +505,13 @@ func TestParameterBinding(t *testing.T) {
// See https://github.com/oapi-codegen/runtime/issues/116

t.Run("spaceDelimited array", func(t *testing.T) {
t.Skip("spaceDelimited not yet supported in runtime (oapi-codegen/runtime#116)")
result = testutil.NewRequest().Get("/queryDelimited?sa=3%204%205").GoWithHTTPHandler(t, e)
assert.Equal(t, http.StatusOK, result.Code())
assert.EqualValues(t, expectedArray, ts.array)
ts.reset()
})

t.Run("pipeDelimited array", func(t *testing.T) {
t.Skip("pipeDelimited not yet supported in runtime (oapi-codegen/runtime#116)")
result = testutil.NewRequest().Get("/queryDelimited?pa=3|4|5").GoWithHTTPHandler(t, e)
assert.Equal(t, http.StatusOK, result.Code())
assert.EqualValues(t, expectedArray, ts.array)
Expand Down
2 changes: 0 additions & 2 deletions internal/test/parameters/echov5/echov5_param_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,10 +278,8 @@ func testImpl(t *testing.T, handler http.Handler) {
assert.Equal(t, expectedComplexObject, got.DeepObj)
})
t.Run("spaceDelimited", func(t *testing.T) {
t.Skip("spaceDelimited not yet supported in runtime (oapi-codegen/runtime#116)")
})
t.Run("pipeDelimited", func(t *testing.T) {
t.Skip("pipeDelimited not yet supported in runtime (oapi-codegen/runtime#116)")
})
})

Expand Down
Loading
Loading