Skip to content

fix: allow response error handler to set status code #1963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mromaszewicz merged 5 commits into from
Mar 6, 2026
Merged

fix: allow response error handler to set status code #1963

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
93a9d39
fix: allow response error handler to set status code
sean-cunniffe May 4, 2025
4698faa
Merge branch 'main' into fix/allow-response-err-handler-set-status-code
sean-cunniffe May 14, 2025
3cd0ce4
Merge upstream/main into pr/1963
mromaszewicz Mar 5, 2026
1dedae6
fix: buffer JSON responses before writing headers
mromaszewicz Mar 6, 2026
2b56060
Address Greptile feedback
mromaszewicz Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: buffer JSON responses before writing headers 
JSON responses in strict server Visit*Response functions are now encoded
to a bytes.Buffer before setting headers and calling WriteHeader. This
ensures that if JSON encoding fails, nothing has been written to the
ResponseWriter, allowing ResponseErrorHandlerFunc to set an appropriate
status code (e.g. 500 instead of 200).

Non-JSON content types (text, formdata, multipart, binary/io.Reader)
retain the original headers-first ordering since their write patterns
do not benefit from buffering.

Adds regression tests for all content type paths and an integration test
verifying that ResponseErrorHandlerFunc can set the status code when
JSON encoding fails.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
  • Loading branch information
@mromaszewicz @claude
mromaszewicz and claude committed Mar 6, 2026
commit 1dedae6c8a2914b1e42198a1515a5f37f5f4f97f
9 changes: 7 additions & 2 deletions internal/test/issues/issue-1093/api/child/child.gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 7 additions & 2 deletions internal/test/issues/issue-1093/api/parent/parent.gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

36 changes: 28 additions & 8 deletions internal/test/issues/issue-1208-1209/issue-multi-json.gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions internal/test/issues/issue-1212/pkg1/pkg1.gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 14 additions & 4 deletions internal/test/issues/issue-1378/bionicle/bionicle.gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 14 additions & 4 deletions internal/test/issues/issue-1378/fooservice/fooservice.gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

27 changes: 21 additions & 6 deletions internal/test/issues/issue-1529/strict-echo/issue1529.gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions internal/test/issues/issue-1676/ping.gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions internal/test/issues/issue-1963/config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
package: issue1963
output: issue1963.gen.go
generate:
std-http-server: true
strict-server: true
models: true
3 changes: 3 additions & 0 deletions internal/test/issues/issue-1963/generate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
package issue1963

//go:generate go run github.com/oapi-codegen/oapi-codegen/v2/cmd/oapi-codegen --config=config.yaml spec.yaml
Loading