Skip to content

New addon api versioning approach #9151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feerrenrut merged 37 commits into from
Jan 31, 2019
Merged

New addon api versioning approach #9151

Changes from 1 commit
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
0300289
Move version string regex add tests
feerrenrut Dec 15, 2018
2e939a0
Replace compatibility checks
feerrenrut Dec 15, 2018
d2f8c53
Keep API versions as tuples
feerrenrut Dec 21, 2018
a3723f6
Dont show incompat addons dialog on startup
feerrenrut Jan 7, 2019
ff117c9
fix logic error: enable show incompat addons dialog button
feerrenrut Jan 10, 2019
7c15c4d
Remove need to manually call destroy on IncompatibleAddonsDialog
feerrenrut Jan 10, 2019
07de7d1
Fix freeze on exit when destroy not called manually for AutoWidthColu…
feerrenrut Jan 10, 2019
79dff12
Ensure confirmation checkbox has focus for all installer warnings
feerrenrut Jan 10, 2019
3fb5087
Set a new, more accurate label
feerrenrut Jan 10, 2019
8270385
Fix wording of button
feerrenrut Jan 10, 2019
6096af2
Re-order params and make them not optional.
feerrenrut Jan 10, 2019
b0e79f2
Add an "addon information" button to the incompatible addons list dialog
feerrenrut Jan 10, 2019
ef10db5
Removes unnecessary code
feerrenrut Jan 10, 2019
9d7eb43
Validate manifest condition: minRequiredVersion <= lastTested
feerrenrut Jan 10, 2019
b8f22de
update the user guide
feerrenrut Jan 10, 2019
beb0343
remove unnecessary check for manifest errors
feerrenrut Jan 11, 2019
03bcf42
Raise error for failed audioducking unless its access denied
feerrenrut Jan 11, 2019
222276a
improve consitency of messages for incompatible addons
feerrenrut Jan 11, 2019
d07981e
Further consistency of wording in GUI
feerrenrut Jan 13, 2019
896b2be
Review actions for #9151
feerrenrut Jan 14, 2019
c3ba83c
Extract version formatting into functions
feerrenrut Jan 14, 2019
b75bbcc
use `_setStateToNone(state)` to initialise state dict
feerrenrut Jan 14, 2019
0de603e
Fix userguide wording.
feerrenrut Jan 14, 2019
69d8b0a
Audio ducking failed warning
feerrenrut Jan 15, 2019
9ba7b77
Addon install warning / error dialog sounds
feerrenrut Jan 15, 2019
c9da315
Use context manager for writing to file.
feerrenrut Jan 15, 2019
42d6eb4
Stop incompatible addons from mutating the disabled state of addons.
feerrenrut Jan 15, 2019
f18136c
fix translator comment errors
feerrenrut Jan 16, 2019
250a46d
Review actions #9151
feerrenrut Jan 16, 2019
30de90f
Try to reduce confusion in the addToPackagePath method
feerrenrut Jan 17, 2019
5e77fcb
Improve comment in `addToPackagePath`
feerrenrut Jan 18, 2019
d62d356
Remove unused function
feerrenrut Jan 29, 2019
a6b45f0
Tidy addon installation
feerrenrut Jan 29, 2019
db76178
Clarified formatting of version strings.
feerrenrut Jan 30, 2019
89281cc
Renamed _showAddonUntestedDialog
feerrenrut Jan 30, 2019
47640ff
Updated developer guide.
feerrenrut Jan 31, 2019
0883ef8
Update changes file for #9151
feerrenrut Jan 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove unnecessary check for manifest errors 
This is already checked (and an AddonError raised) when creating the Addon
  • Loading branch information
@feerrenrut
feerrenrut committed Jan 11, 2019
commit beb03430f7c9263a40a150ec335bf61cf6d2630b
3 changes: 0 additions & 3 deletions source/addonHandler/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,9 +196,6 @@ def _getAvailableAddonsFromPath(path):
name=name,
a=a
))
if a.manifest.errors is not None:
_report_manifest_errors(a.manifest)
raise AddonError("Manifest file has errors.")
if a.isDisabled:
log.debug("Disabling add-on %s", name)
elif not isAddonCompatible(a):
Expand Down