Skip to content

Support the HTML5 required attribute in MSHTML documents #7321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaelDCurran merged 4 commits into from
Sep 5, 2017
Merged

Support the HTML5 required attribute in MSHTML documents #7321

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
100b19a
Support the HTML5 required attribute in MSHTML documents
Jun 24, 2017
b1f17b1
Add a new __contains__ function to the HTMLAttribCache
Jun 28, 2017
163b8c9
Support HTML5 required in MSHTML focus mode
Jun 28, 2017
d4de85d
Review action, still some open ones
Jul 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Review action, still some open ones
  • Loading branch information
Leonard de Ruijter
Leonard de Ruijter committed Jul 18, 2017
commit d4de85dc342985a114800cf1f8d28bf4272cdc2c
15 changes: 6 additions & 9 deletions source/NVDAObjects/IAccessible/MSHTML.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,15 +90,12 @@ def __contains__(self,item):
return self.containsCache[item]

@michaelDCurran michaelDCurran Jul 5, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then change this to return item in self.containsCache

@LeonarddeR LeonarddeR Jul 5, 2017

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we do this, the block below that actually runs hasAttribute never gets executed.

except LookupError:
pass
value = self[item]
if value is not None:
contains = True
self.containsCache[item]=contains
return contains
try:
contains= self.HTMLNode.hasAttribute(item)
except (COMError,NameError):
contains = False
contains=item in self.cache
if not contains:
try:
contains=self.HTMLNode.hasAttribute(item)
except (COMError,NameError):
pass
self.containsCache[item]=contains
return contains

Expand Down