Skip to content

fix: handle COMError in UIA selectionContainer to prevent silent focus #20255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seanbudd merged 2 commits into from
Jun 1, 2026
Merged

fix: handle COMError in UIA selectionContainer to prevent silent focus #20255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e415b58
fix: handle COMError in UIA selectionContainer to prevent silent focus
rezabakhshilaktasaraei May 31, 2026
71b2c59
Add PR number to changelog entry
rezabakhshilaktasaraei May 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion source/NVDAObjects/UIA/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1690,7 +1690,13 @@ def _get_selectionContainer(self) -> "typing.Optional[UIA]":
p = self.UIASelectionItemPattern
if not p:
return None
e = p.currentSelectionContainer
try:
e = p.currentSelectionContainer
except COMError:
# Some providers (e.g. Qt's QWindowsUiaSelectionItemProvider when the
# accessible has no actionInterface) raise instead of returning a value.
# Treat the same as no selection container so focus speech is not aborted.
return None
if not e:
# Some implementations of SelectionItemPattern, such as the Outlook attachment list
# give back a NULL selectionContainer
Expand Down
1 change: 1 addition & 0 deletions user_docs/en/changes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,7 @@ The setting is disabled by default. (#20013, @LeonarddeR)
* Fixed NVDA freezing when navigating in JetBrains IDEs. (#16741, @christopherpross)
* Speech dictionary entries of type Whole word now correctly handle words containing Unicode combining marks (e.g. Hebrew niqqud, Arabic harakat). (#20013, @LeonarddeR)
* In particular, Whole word entries no longer incorrectly match inside larger words when those words contain combining marks.
* Focus is no longer silent on list items in Qt-based applications (such as Telegram Desktop) when the item exposes the UIA SelectionItem pattern without an associated action interface. (#20255, @rezabakhshilaktasaraei)

### Changes for Developers

Expand Down
Loading