Skip to content

Convert ui.browseableMessage to wx.html2.WebView #20251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seanbudd merged 25 commits into from
Jun 17, 2026
Merged

Convert ui.browseableMessage to wx.html2.WebView #20251

Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
ae70597
Webview browseable message prototype
LeonarddeR Sep 8, 2025
426fc6f
Fixings
LeonarddeR May 28, 2026
5ceab04
Rework browseableMessage to use wx.html2.WebView via MessageDialog
LeonarddeR May 28, 2026
5b36a82
Fix
LeonarddeR May 29, 2026
d957f44
Refactor browseable message into an HtmlMessageDialog subclass
LeonarddeR May 29, 2026
b13909b
Align browseable message copy with the About dialog
LeonarddeR May 29, 2026
d19af95
Pre-commit auto-fix
pre-commit-ci[bot] May 29, 2026
926c251
Add change log entries for the browseable message rework
LeonarddeR May 29, 2026
c4d27ec
Fixup
LeonarddeR May 30, 2026
376ceac
Add system tests
LeonarddeR May 30, 2026
6d0f08d
Pre-commit auto-fix
pre-commit-ci[bot] May 30, 2026
84b83d2
HtmlMessageDialog: allow showing without buttons; fix Escape
LeonarddeR May 30, 2026
2ed6d5b
Pre-commit auto-fix
pre-commit-ci[bot] May 30, 2026
3ef6466
Add note about edge and wx python limitaitons
LeonarddeR May 30, 2026
837c4b4
Ensure IE11 emu
LeonarddeR May 30, 2026
811ca7a
Pre-commit auto-fix
pre-commit-ci[bot] May 30, 2026
9515b03
Remove not supported IE emulation level option
LeonarddeR Jun 1, 2026
b5758eb
Merge remote-tracking branch 'origin/master' into browsableWebview
LeonarddeR Jun 1, 2026
d26c8e8
Merge remote-tracking branch 'origin/master' into browsableWebview
LeonarddeR Jun 2, 2026
4a0b336
Add deprecation strategy
LeonarddeR Jun 2, 2026
2d7fd1d
Review actions
LeonarddeR Jun 2, 2026
cdf0fe6
Remove Show override
LeonarddeR Jun 8, 2026
4b4897e
Ensure that _onNavigating supports an override to Edge in future
LeonarddeR Jun 10, 2026
46664f7
Merge remote-tracking branch 'origin/master' into browsableWebview
LeonarddeR Jun 17, 2026
6596d76
Specify deprecated values inline
LeonarddeR Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Pre-commit auto-fix
  • Loading branch information
@pre-commit-ci
pre-commit-ci[bot] committed May 30, 2026
commit 2ed6d5b307de64d3fc49dffeb84329e7e9d133bf
10 changes: 7 additions & 3 deletions source/gui/message.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1216,9 +1216,13 @@ def __init__(self, *args, **kwargs):
# child window, so Escape reliably triggers Close() regardless of what IE does with it.
escapeId = wx.NewIdRef()
self.Bind(wx.EVT_MENU, lambda evt: self.Close(), id=escapeId)
self.SetAcceleratorTable(wx.AcceleratorTable([
wx.AcceleratorEntry(wx.ACCEL_NORMAL, wx.WXK_ESCAPE, escapeId),
]))
self.SetAcceleratorTable(
wx.AcceleratorTable(
[
wx.AcceleratorEntry(wx.ACCEL_NORMAL, wx.WXK_ESCAPE, escapeId),
]
),
)

def registerAction(self, action: str, handler: Callable[[], None]) -> Self:
"""Register a handler for an ``nvda-action://<action>`` URL triggered from the HTML message.
Expand Down
Loading