Skip to content

Use IA2 math attribute instead of ISimpleDOM when possible #20049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seanbudd merged 10 commits into from
May 5, 2026
Merged

Use IA2 math attribute instead of ISimpleDOM when possible #20049

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ab8de2e
Use IA2 math attribute for MathML in Chromium
RyanMcCleary May 4, 2026
7c36c30
Added debug log
RyanMcCleary May 4, 2026
4516529
Add changelog entry
RyanMcCleary May 4, 2026
364144e
Fix comment
RyanMcCleary May 4, 2026
309c73d
Log only first 100 chars of mathML
RyanMcCleary May 4, 2026
5cb3fcf
Update source/NVDAObjects/IAccessible/ia2Web.py
RyanMcCleary May 4, 2026
4c9aeaa
Pre-commit auto-fix
pre-commit-ci[bot] May 4, 2026
a0f292c
Add missing import
RyanMcCleary May 4, 2026
2ec13db
Merge remote-tracking branch 'upstream/master' into ia2-math-attr
RyanMcCleary May 4, 2026
50c8cb6
Remove unrelated issue template documentation changes
RyanMcCleary May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added debug log
  • Loading branch information
@RyanMcCleary
RyanMcCleary committed May 4, 2026
commit 7c36c307f89c5ceff23f6e791c754be2529d0368
4 changes: 3 additions & 1 deletion source/NVDAObjects/IAccessible/ia2Web.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,9 @@ def _get_mathMl(self):
mathAttr = re.sub(r"<!--.*?-->", "", mathAttr, flags=re.DOTALL)

langAttr = f' xml:lang="{self.language}"' if self.language else ""
return f"<math{langAttr}>{mathAttr}</math>"
mathMl = f"<math{langAttr}>{mathAttr}</math>"
log.debug(f"Got MathML from IA2 math attribute: {mathMl!r}")
Comment thread
RyanMcCleary marked this conversation as resolved.
Outdated
return mathMl

from comtypes.gen.ISimpleDOM import ISimpleDOMNode # type: ignore[reportMissingImports]

Expand Down
Loading