Skip to content

Redact secrets when logging config and warn user when changing categories #19966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seanbudd merged 30 commits into from
Apr 22, 2026
Merged

Redact secrets when logging config and warn user when changing categories #19966

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
3175d14
Redact secrets when logging
seanbudd Apr 17, 2026
e3a0dea
Apply suggestions from code review
seanbudd Apr 17, 2026
a0702a8
fix inclusion
seanbudd Apr 17, 2026
94c1668
fix up detection and formatting
seanbudd Apr 17, 2026
520d9bc
Pre-commit auto-fix
pre-commit-ci[bot] Apr 17, 2026
098b3cb
document changes
seanbudd Apr 17, 2026
fb2fe7e
review suggestions
seanbudd Apr 17, 2026
9b266b5
Pre-commit auto-fix
pre-commit-ci[bot] Apr 17, 2026
a2551f4
add unit tests
seanbudd Apr 17, 2026
c15a546
Pre-commit auto-fix
pre-commit-ci[bot] Apr 17, 2026
86851a5
Merge remote-tracking branch 'origin/master' into detectSecrets
seanbudd Apr 20, 2026
f58c1f6
fix detect_secrets inclusion
seanbudd Apr 20, 2026
cb35311
fix up
seanbudd Apr 20, 2026
143bd04
Merge remote-tracking branch 'origin/master' into detectSecrets
seanbudd Apr 21, 2026
bec0131
Add log level and warning
seanbudd Apr 21, 2026
cdc846f
Fix behaviour
seanbudd Apr 21, 2026
2d8e7ed
Merge remote-tracking branch 'origin/master' into detectSecrets
seanbudd Apr 21, 2026
0b52053
Pre-commit auto-fix
pre-commit-ci[bot] Apr 21, 2026
3177144
fix elif
seanbudd Apr 21, 2026
43d007b
Add help id
seanbudd Apr 21, 2026
ccc6aa2
Apply suggestion from @seanbudd
seanbudd Apr 21, 2026
00eb8bf
Apply suggestion from @seanbudd
seanbudd Apr 21, 2026
8f54736
restore mathcat?
seanbudd Apr 21, 2026
f0c7c4b
Merge remote-tracking branch 'refs/remotes/origin/detectSecrets' into…
seanbudd Apr 21, 2026
49b2043
Update source/logHandler.py
seanbudd Apr 21, 2026
3924102
Update source/logHandler.py
seanbudd Apr 21, 2026
7c982ff
line end
seanbudd Apr 22, 2026
c71c883
Merge remote-tracking branch 'origin/master' into detectSecrets
seanbudd Apr 22, 2026
85dab52
fix ineq
seanbudd Apr 22, 2026
8a70eba
Merge remote-tracking branch 'origin/master' into detectSecrets
seanbudd Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
line end
  • Loading branch information
@seanbudd
seanbudd committed Apr 22, 2026
commit 7c982ffa272ab0abd4b369229c365da23d83ab81
2 changes: 1 addition & 1 deletion .github/instructions/python.instructions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
applyTo: **/*.py, **/*.pyw
applyTo: **/*.py, **/*.pyw
description: This file describes the Python code style for the project.
---

Expand Down
2 changes: 1 addition & 1 deletion .github/instructions/review.instructions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Use these instructions when reviewing pull requests in this repository.

## Review goals

* Prioritize correctness, positive accessibility impact, API compatibility, security and avoiding regressions.
* Prioritize correctness, positive accessibility impact, API compatibility, security and avoiding regressions.
* Keep feedback specific and actionable; prefer concrete code suggestions over generic comments.
* Classify issues by severity:
* **Blocking**: likely bug, regression risk, security concern, API break, missing required tests/docs.
Expand Down