Repository navigation
Fix version comparisons when installing/updating/downgrading #19631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
90b51c3
fix version comparisons
seanbudd 3ef6cb2
import fileUtils
seanbudd cfa8ef7
fix up parsing logic
seanbudd a0b01d5
fix up parsing logic
seanbudd b1b487d
minor fixes
seanbudd 49bc979
Update source/fileUtils.py
seanbudd ab82529
change default arg for startOnLogon param of doInstall
seanbudd 3b677a6
add better back compat handling
seanbudd 9aec218
don't show warning dialog on reinstall, it should be safe
seanbudd 40a9f8d
add unit tests
seanbudd 6655f7f
Merge branch 'beta' into fixCompareVersion
seanbudd 6795c7c
fixup unit tests
seanbudd cd3a790
Update source/installer.py
seanbudd ec89563
Update source/installer.py
seanbudd d35fd73
polish up
seanbudd 8f77aff
Pre-commit auto-fix
pre-commit-ci[bot] 760a19c
Add warning text
seanbudd 8fd79ff
Merge remote-tracking branch 'origin/fixCompareVersion' into fixCompa…
seanbudd a994392
fix import
seanbudd 4d21e2b
fix up issues
seanbudd a09370a
use lambda
seanbudd f809b0d
fix portable copies
seanbudd 8145d15
use diff messages
seanbudd c814204
Pre-commit auto-fix
pre-commit-ci[bot] f585227
fix prevcopyexists
seanbudd 90daa69
Merge remote-tracking branch 'origin/fixCompareVersion' into fixCompa…
seanbudd 4202fa8
pass in state
seanbudd b25022b
Update user_docs/en/changes.md
seanbudd 26c95a0
Apply suggestions from code review
seanbudd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
use diff messages
- Loading branch information
commit 8145d159927d32839ac071b0e323f6d3a38d08e0
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.