Skip to content

Persist remote connect dialog options #18601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SaschaCowley merged 11 commits into from
Aug 8, 2025
Merged

Persist remote connect dialog options #18601

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8c5c44a
Remember last selected connection mode
SaschaCowley Aug 1, 2025
0bd4ade
Change log
SaschaCowley Aug 1, 2025
7dcc1a1
Set up GUI persistence
SaschaCowley Aug 6, 2025
8638f33
Use persistenceManager to save mode
SaschaCowley Aug 6, 2025
4756bba
Remember server type
SaschaCowley Aug 6, 2025
3d69544
Use a more modular approach
SaschaCowley Aug 6, 2025
be3906f
Tidy up
SaschaCowley Aug 6, 2025
9538448
Remember port
SaschaCowley Aug 6, 2025
2cd8d74
Merge branch 'master' into rememberLastMode
SaschaCowley Aug 6, 2025
72ee565
Changes for devs
SaschaCowley Aug 6, 2025
dcf43f3
Remove stragglers
SaschaCowley Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Remember last selected connection mode
  • Loading branch information
@SaschaCowley
SaschaCowley committed Aug 1, 2025
commit 8c5c44a193a696e09f7778aefc2ed5ecc248896c
5 changes: 4 additions & 1 deletion source/_remoteClient/dialogs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,7 @@ def __init__(self, parent: wx.Window, id: int, title: str, hostnames: list[str]
wx.Choice,
choices=tuple(mode.displayString for mode in RemoteConnectionMode),
)
self._connectionModeControl.SetSelection(0)
self._connectionModeControl.SetSelection(configuration.getRemoteConfig()["ui"]["lastConnectionMode"])
self._clientOrServerControl = contentsSizerHelper.addLabeledControl(
# Translators: Label of the control allowing users to select whether to use a pre-existing Remote Access server, or to run their own.
pgettext("remote", "&Server:"),
Expand Down Expand Up @@ -387,6 +387,9 @@ def _onOk(self, evt: wx.CommandEvent) -> None:
if focusTarget is not None:
focusTarget.SetFocus()
else:
configuration.getRemoteConfig()["ui"]["lastConnectionMode"] = (
self._connectionModeControl.GetSelection()
)
evt.Skip()

def _getKey(self) -> str:
Expand Down
2 changes: 2 additions & 0 deletions source/config/configSpec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,6 +362,8 @@
__many__ = string(default="")
[[ui]]
confirmDisconnectAsFollower = boolean(default=True)
# 0: follower, 1: leader
Comment thread
SaschaCowley marked this conversation as resolved.
Outdated
lastConnectionMode = integer(default=0, min=0, max=1)
Comment thread
SaschaCowley marked this conversation as resolved.
Outdated
Comment thread
SaschaCowley marked this conversation as resolved.
Outdated
"""

#: The configuration specification
Expand Down