Skip to content

Report spelling errors with a sound while reading #17997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SaschaCowley merged 49 commits into from
Sep 5, 2025
Merged

Report spelling errors with a sound while reading #17997

Changes from 1 commit
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
7472426
Report spelling errors with a sound while reading
Apr 18, 2025
bc96c36
Change log
Apr 22, 2025
30b5b75
Pre-commit auto-fix
pre-commit-ci[bot] Apr 22, 2025
fed0575
Fix pre-commit rework - adding tailing comma
Apr 23, 2025
d42f3ef
Apply suggestions from code review
CyrilleB79 May 5, 2025
fcf6afb
Change anchor name
May 5, 2025
72b2025
Remove debug comments
May 5, 2025
ecee988
Merge branch 'master' into spellingSound
May 7, 2025
743a5a5
Merge branch 'master' into spellingSound
CyrilleB79 Jun 3, 2025
579f3b1
Merge branch 'master' into spellingSound
Jul 8, 2025
5696410
Convert to new key; feature broken in Word (UIA or legacy)
Jul 8, 2025
44f72b0
Merge branch 'master' into spellingSound
Aug 5, 2025
b88944f
Fix config latest after merge
Aug 5, 2025
70770bb
Implement aliases
Aug 5, 2025
c7905cf
Fix and document config key aliasing
Aug 6, 2025
f2fc880
Merge branch 'master' into spellingSound
Aug 6, 2025
4b7670a
Pre-commit auto-fix
pre-commit-ci[bot] Aug 6, 2025
263c027
Apply suggestions from code review
CyrilleB79 Aug 7, 2025
03f5b09
Fix type hint
Aug 7, 2025
72b3d41
Merge branch 'master' into spellingSound
Aug 8, 2025
3b5219e
Apply suggestions from code review
CyrilleB79 Aug 8, 2025
d3676cc
Added unit tests
Aug 8, 2025
bb0a58e
Pre-commit auto-fix
pre-commit-ci[bot] Aug 8, 2025
41aaecd
Merge branch 'master' into spellingSound
Aug 8, 2025
658fd7e
Pre-commit auto-fix
pre-commit-ci[bot] Aug 8, 2025
da2d886
Bump CI
Aug 8, 2025
c4e5e97
Update tests/unit/test_config.py
SaschaCowley Aug 19, 2025
660049c
Merge branch 'master' into spellingSound
CyrilleB79 Aug 28, 2025
bce05e3
Remove backward compa code since we now target 2026.1
CyrilleB79 Aug 28, 2025
cba9bfa
ReportSpellingErrors converted to DisplayStringIntFlag; usage to be u…
CyrilleB79 Aug 28, 2025
602a05e
Pre-commit auto-fix
pre-commit-ci[bot] Aug 28, 2025
aeac6b8
Convert to bitwise flag everywhere
Aug 29, 2025
0e92ea7
fix translator's comment
Aug 29, 2025
156ea3a
Update change for dev
Aug 29, 2025
1cfe185
Update User §Guide with checklist box
Aug 29, 2025
cb6d06f
Fix config upgrade
Aug 29, 2025
3a7db06
Pre-commit auto-fix
pre-commit-ci[bot] Aug 29, 2025
1f6c43d
type hint
Aug 29, 2025
e324235
Fix syntax error
Aug 29, 2025
8f5ca89
Pre-commit auto-fix
pre-commit-ci[bot] Aug 29, 2025
3008570
Fix missing import
Aug 29, 2025
7a9810e
One more attempt to fix translators comment!
Aug 29, 2025
3087fa6
Fix both reporting modes
CyrilleB79 Aug 30, 2025
5103c8b
Pre-commit auto-fix
pre-commit-ci[bot] Aug 30, 2025
d3a156e
Apply suggestions from code review
CyrilleB79 Sep 2, 2025
6a0437b
Merge branch 'master' into spellingSound
CyrilleB79 Sep 3, 2025
4c2b721
Remove unnecessary if
CyrilleB79 Sep 3, 2025
bc29cb4
Update source/config/profileUpgradeSteps.py
SaschaCowley Sep 5, 2025
94b65d9
Pre-commit auto-fix
pre-commit-ci[bot] Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix type hint
  • Loading branch information
Cyrille Bougot
Cyrille Bougot committed Aug 7, 2025
commit 03f5b09e7c185fff5a5763d2324c91d015cf69c2
2 changes: 1 addition & 1 deletion source/config/configFlags.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ class ReportSpellingErrors(DisplayStringIntEnum):
SOUND = 2

@property
def _displayStringLabels(self) -> dict[ReportSpellingErrors, str]:
def _displayStringLabels(self) -> dict["ReportSpellingErrors", str]:
return {
# Translators: A choice in a combo box in the document formatting dialog to not report spelling errors.
ReportSpellingErrors.OFF: pgettext("reportSpellingErrorsSetting", "Off"),
Expand Down