Repository navigation
Report the language of the text been read #17685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
218 commits
Select commit
Hold shift + click to select a range
7be8bd2
Add ability to report the current language when detecting languages i…
nvdaes f0a9a31
Added a command to report the language of the character at the caret
nvdaes 6e4b0b3
Apply suggestions from code review
nvdaes 79e9bb5
Address review and minor improvements
nvdaes 2393d8a
Use _speechState
nvdaes df8d7c2
Merge remote-tracking branch 'nvaccess/master' into reportSwitchLang
nvdaes bb3b7c6
Fix reporting when using quick navigation, avoiding repetition of the…
nvdaes e70b380
Pre-commit auto-fix
pre-commit-ci[bot] 8e437d0
Don't report language description on quick nav
nvdaes e898b6c
Suppress language description reporting when reading all and a block …
nvdaes 7123970
Don't try to change behavior in read all, seems to be useless
nvdaes 2164376
Merge remote-tracking branch 'nvaccess/master' into reportSwitchLang
nvdaes 2eca960
Prevent insertion of None in speech sequence
nvdaes fb54393
Merge remote-tracking branch 'nvaccess/master' into reportSwitchLang
nvdaes 4b47171
Merge master
nvdaes eefc66e
Add ability to configure reporting of language switched to
nvdaes bebb1cf
Update user guide
nvdaes 87f9fe4
Fix comments for translators
nvdaes d5ef866
Update changelog
nvdaes 0924453
Remove Coptic grade 1 braille table to fix unit tests (to be reviewed)
nvdaes 2ca26ee
Revert "Remove Coptic grade 1 braille table to fix unit tests (to be …
nvdaes c419507
Checkout liblouis
nvdaes 64ebd49
Apply suggestions from code review
nvdaes 0261210
Address review
nvdaes 56b9511
Merge remote-tracking branch 'nvaccess/master' into reportSwitchLang
nvdaes b4abebf
Reset speech
nvdaes 7652da7
Use filter speech sequence
nvdaes 2c5d59c
Pre-commit auto-fix
pre-commit-ci[bot] 4c76ecf
Update speech.speech
nvdaes 9b6222a
Update speech.speech
nvdaes d323880
Merge branch 'reportSwitchLang' of https://github.com/nvdaes/nvda int…
nvdaes f1b1c4f
Save last reported language
nvdaes db9afa9
Pre-commit auto-fix
pre-commit-ci[bot] 59e39aa
Report language with default voice
nvdaes d48cc00
Merge branch 'reportSwitchLang' of https://github.com/nvdaes/nvda int…
nvdaes c04ff30
Append not supported for languages when appropriate
nvdaes bb213ee
Add function to know if language is supported
nvdaes 897b5f8
Improve function to filter sequences with language descriptions
nvdaes 6ff7b2d
Remove unused import
nvdaes 9a4abec
Improve readability of function
nvdaes 8b25398
Move functions to speech module2
nvdaes d826f01
Pre-commit auto-fix
pre-commit-ci[bot] a3dcab6
Return original speech sequence if report language setting is False
nvdaes 09e1113
Merge branch 'reportSwitchLang' of https://github.com/nvdaes/nvda int…
nvdaes 4936928
Merge master branch
nvdaes cedf598
Address review: add comment for translators
nvdaes 002727c
Merge remote-tracking branch 'nvaccess/master' into reportSwitchLang
nvdaes e3aaf14
Apply suggestions from code review
nvdaes 710699e
Add type hint for script, addressing code review
nvdaes 2847e51
Merge remote-tracking branch 'nvaccess/master' into reportSwitchLang
nvdaes 740d65e
Fix syntax
nvdaes 258a0dd
Address review: move function to SynthDriver
nvdaes 8b5b144
Update synthDriverHandler
nvdaes bfad3aa
Add return type
nvdaes eb8e5ea
Add copyrigh header
nvdaes b722d9e
Report not supported languages with speech or beep
nvdaes f89aa74
Pre-commit auto-fix
pre-commit-ci[bot] 38b1085
Lint
nvdaes 206d45f
Merge branch 'reportSwitchLang' of https://github.com/nvdaes/nvda int…
nvdaes 7c5501b
Use ReportNotSupportedLanguage enum
nvdaes 42e5ee6
Report not supported language also if report language is disabled
nvdaes c512161
Format languageHandling
nvdaes 62c0cc4
Better handling of reporting languages
nvdaes ce9d447
Better handling of report language
nvdaes 32f933e
Merge remote-tracking branch 'nvaccess/master' into reportSwitchLang
nvdaes ca27eac
Update changelog
nvdaes ec46447
Merge remote-tracking branch 'nvaccess/master' into reportSwitchLang
nvdaes b3328c9
Pre-commit auto-fix
pre-commit-ci[bot] 9f20f94
Update user guide and anchor for combo box to report not supported la…
nvdaes 78fa8f8
Pre-commit auto-fix
pre-commit-ci[bot] 6bcfd87
Better indentation of changelog
nvdaes deb74c4
Pre-commit auto-fix
pre-commit-ci[bot] 1d548c1
Apply suggestions from code review
nvdaes ff7fceb
Address review
nvdaes 4689062
Pre-commit auto-fix
pre-commit-ci[bot] ce3a877
Enable controls to report language when auto language switching is en…
nvdaes ba7d249
Merge branch 'reportSwitchLang' of https://github.com/nvdaes/nvda int…
nvdaes 428bb97
Pre-commit auto-fix
pre-commit-ci[bot] 70b6d95
Update globalCommands.py
nvdaes 82327bd
Revert "Update globalCommands.py"
nvdaes 117020b
Merge remote-tracking branch 'nvaccess/master' into reportSwitchLang
nvdaes cd0395d
Update changelog
nvdaes c31f8ba
Update miscDeps
nvdaes ca90217
Use pgettext for report language options, addressing code review
nvdaes d040dca
Pre-commit auto-fix
pre-commit-ci[bot] 187491b
Add docstring for lastReportedLanguage
nvdaes 2476b39
Merge
nvdaes a054717
Merge
nvdaes 8099a30
Pre-commit auto-fix
pre-commit-ci[bot] b6b6b18
Remove utf-8 coding declaration
nvdaes b48a936
Merge branch 'reportSwitchLang' of https://github.com/nvdaes/nvda int…
nvdaes 234e85c
Update source/gui/settingsDialogs.py
nvdaes accb7b7
Add pgettext to string
nvdaes 4dc4bde
Merge branch 'reportSwitchLang' of https://github.com/nvdaes/nvda int…
nvdaes decde23
Pre-commit auto-fix
pre-commit-ci[bot] b362222
Don't enable report language ccheckbox deppending on auto language de…
nvdaes 66322ec
Merge branch 'reportSwitchLang' of https://github.com/nvdaes/nvda int…
nvdaes f9521a5
Pre-commit auto-fix
pre-commit-ci[bot] f42353e
Allow to report language for characters even if auto language detecti…
nvdaes fc65eff
Merge branch 'reportSwitchLang' of https://github.com/nvdaes/nvda int…
nvdaes c543196
Address review
nvdaes 732074d
Fix translators comments
nvdaes 99fe541
Add report language command to user guide
nvdaes efa0435
Fix comment for translators
nvdaes e6dcd40
Fix comment for translators
nvdaes dfe24fd
Merge branch 'master' into reportSwitchLang
nvdaes 32bbe12
Fix reporting of not supported language
nvdaes b73f814
Merge remote-tracking branch 'nvaccess/master' into reportSwitchLang
nvdaes 5beae67
Add onlyCache to LangChangeCommand
nvdaes 42c5960
Merge remote-tracking branch 'nvaccess/master' into reportSwitchLang
nvdaes d40abb4
Handle onlyCache in LangChangeCommand for speech.speech file
nvdaes 8859309
Pre-commit auto-fix
pre-commit-ci[bot] 913987a
Update speech
nvdaes 8d1df38
Merge branch 'reportSwitchLang' of https://github.com/nvdaes/nvda int…
nvdaes e29479a
Make auto language detection to work again
nvdaes 6282abc
Pre-commit auto-fix
pre-commit-ci[bot] 9649877
Make reporting language to work again, regardless of auto language de…
nvdaes 1069ea9
Merge branch 'reportSwitchLang' of https://github.com/nvdaes/nvda int…
nvdaes 0c2e5de
Minor improvements
nvdaes 0e256d9
Pre-commit auto-fix
pre-commit-ci[bot] 7e0d4cc
Report language changes in the same sentence when auto language switc…
nvdaes 82d52bf
Merge branch 'reportSwitchLang' of https://github.com/nvdaes/nvda int…
nvdaes 6e6d213
Remove log.info
nvdaes f4f1661
Address review: remove default from choice
nvdaes 2aae249
Use NotSupportedLanguage class in speech
nvdaes ac37c90
Pre-commit auto-fix
pre-commit-ci[bot] c6a99b5
Add comments to clarify code
nvdaes cd24509
Merge branch 'reportSwitchLang' of https://github.com/nvdaes/nvda int…
nvdaes 0339c2d
Update changelog
nvdaes f40c3af
Apply suggestions from code review
nvdaes 0f63bd6
Improve comment for translators
nvdaes c01aadd
Reset speech/commands
nvdaes 72d0ac2
Add staticmethods to LangChangeCommand
nvdaes 2f430b5
Use staticmethods added to LangChangeCommand
nvdaes 98f6d1f
Improve function in LangChangeCommand
nvdaes 304bfff
Fix function in LangChangeCommand
nvdaes 66d6f0c
Removed unused variable
nvdaes bd656dc
Add changes for developers
nvdaes a6f12ae
Merge remote-tracking branch 'nvaccess/master' into reportSwitchLang
nvdaes 49b8abd
Apply suggestions from code review
nvdaes cf48a76
Pre-commit auto-fix
pre-commit-ci[bot] bd9c2f3
Partial address review
nvdaes a8feaa3
Merge remote-tracking branch 'nvaccess/master' into reportSwitchLang
nvdaes 3993ed6
Replace autoLanguageSwitching with LangChangeCommand static method
nvdaes 932e8b7
Improvements to gui and languageHandler
nvdaes 629dfa9
Pre-commit auto-fix
pre-commit-ci[bot] d134034
Avoid keeping options to report not supported language when auto lang…
nvdaes 0351dea
Merge branch 'reportSwitchLang' of https://github.com/nvdaes/nvda int…
nvdaes 8c02d81
Fix globalCommands
nvdaes 9bbd37d
Don't report not supported when it's off, honour this setting in glob…
nvdaes 6cceb17
Simplify script
nvdaes 6aed777
Apply suggestions from code review
nvdaes d2c6ded
Pre-commit auto-fix
pre-commit-ci[bot] 6e60580
Merge remote-tracking branch 'nvaccess/master' into reportSwitchLang
nvdaes 6fddc8c
Restore nsis
nvdaes d1cbcdb
Move static methods to languageHandling
nvdaes bc12969
Pre-commit auto-fix
pre-commit-ci[bot] 5ee5c8d
Merge remote-tracking branch 'nvaccess/master' into reportSwitchLang
nvdaes 60a1a90
Address review
nvdaes a1f6ae2
Update user guide
nvdaes 1c19669
Update speech manager
nvdaes 3aaa8c7
Consider case where not supported language shouldn't be reported
nvdaes 04059a3
Pre-commit auto-fix
pre-commit-ci[bot] e6158b3
Apply suggestions from code review
nvdaes 8224d68
Fix script to report language of text been read
nvdaes ce3b842
Improve legibility of function
nvdaes 28aa72e
Pre-commit auto-fix
pre-commit-ci[bot] a18b6f4
Merge remote-tracking branch 'nvaccess/master' into reportSwitchLang
nvdaes f317570
Honour auto dialect switching
nvdaes a9507e8
Add function to determine the language to be reported, according to s…
nvdaes 511c908
Fix getLangToReport function
nvdaes 2bcd47d
Improve getLangToSupport function
nvdaes f63dcb5
Update script to report language of text at caret
nvdaes 8b67ab9
Fix globalCommands
nvdaes 7c6719b
Add a test case for report language feature
nvdaes 89e3619
Pre-commit auto-fix
pre-commit-ci[bot] 91996aa
Fix system tests
nvdaes 47d4b9e
Merge branch 'reportSwitchLang' of https://github.com/nvdaes/nvda int…
nvdaes 5223639
Fix parameter in system tests
nvdaes 3d0cbb0
Fix tests
nvdaes 6c64c9f
Fix test
nvdaes e3ea8fa
Fix test
nvdaes e34e783
Fix typo
nvdaes 2119bfa
Add dialect
nvdaes 1df6ffa
Report languages
nvdaes e5ed8bd
Pre-commit auto-fix
pre-commit-ci[bot] 1169d9c
Install babel for system tests
nvdaes 8a77495
Create function to get the language display name
nvdaes 8f1142f
Pre-commit auto-fix
pre-commit-ci[bot] 0d0d04c
Use babel
nvdaes 2d9a28e
Fix sample
nvdaes da76a30
Test displayName property for Locale
nvdaes 899b63a
Merge remote-tracking branch 'nvaccess/master' into reportSwitchLang
nvdaes 6d0d5a7
Try to use en-US to display name of language
nvdaes 2d156eb
Try to fix test with Babel
nvdaes 0ffd9c7
Don't use system tests
nvdaes 2046afe
Revert "Don't use system tests"
nvdaes 6904799
Restore files
nvdaes cde16ff
Fix test
nvdaes 5f6f090
Fix uv
nvdaes b0b6822
Fix test
nvdaes 7fcc66a
Try to fix test
nvdaes d46b068
Pre-commit auto-fix
pre-commit-ci[bot] 30f811d
Add docstring
nvdaes f1e8c50
Merge branch 'reportSwitchLang' of https://github.com/nvdaes/nvda int…
nvdaes 33cdb13
Change uv.lock
nvdaes 007413b
Try to fix tests
nvdaes 20928de
Pre-commit auto-fix
pre-commit-ci[bot] 79cd544
Test report language without dialects
nvdaes 82c9bd2
Merge branch 'reportSwitchLang' of https://github.com/nvdaes/nvda int…
nvdaes 9ffa729
Report not supported language
nvdaes 56c7528
Fix test
nvdaes 2106b39
Fix test
nvdaes f1f9cdc
Update tests/system/libraries/SystemTestSpy/speechSpyGlobalPlugin.py
nvdaes 01349ce
Merge remote-tracking branch 'nvaccess/master' into reportSwitchLang
nvdaes c40c4fd
Add test to report languages and not supported language
nvdaes 7ca9136
Update user_docs/en/changes.md
seanbudd 56d8211
Update user_docs/en/changes.md
seanbudd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update user_docs/en/changes.md
Co-authored-by: Quentin Christensen <quentin@nvaccess.org>
- Loading branch information
commit 7ca913607f8199466e2d05b6e30befdc73d780a2
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.