Skip to content

Add ability to add more constraints to bdDetect USB device registration #17537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seanbudd merged 22 commits into from
Jan 3, 2025
Merged

Add ability to add more constraints to bdDetect USB device registration #17537

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
33228c6
Refactor fallback and allow match funcs for device registration
LeonarddeR Dec 14, 2024
1b95e81
Update albatross
LeonarddeR Dec 16, 2024
ce4d233
Add changes
LeonarddeR Dec 16, 2024
1791b18
Add brailliant
LeonarddeR Dec 16, 2024
9011882
Actually use the matchFunc and make it optional
LeonarddeR Dec 17, 2024
d0c3bce
Fixup typos
LeonarddeR Dec 20, 2024
b726cf6
Use constant in Albatros
LeonarddeR Dec 20, 2024
98d01bc
Uniform yield
LeonarddeR Dec 20, 2024
3b95bd7
use cache for HID device info
LeonarddeR Dec 26, 2024
673d742
Fix typo
LeonarddeR Dec 26, 2024
dcd8ffd
Deprecations
LeonarddeR Dec 27, 2024
0be066c
Use communication types
LeonarddeR Dec 27, 2024
6908f9d
Renames
LeonarddeR Dec 27, 2024
e18250f
Merge remote-tracking branch 'origin/master' into fallbackRevamp
LeonarddeR Dec 30, 2024
3a485cd
Update source/brailleDisplayDrivers/eurobraille/driver.py
LeonarddeR Dec 30, 2024
edcfe14
Update source/brailleDisplayDrivers/eurobraille/driver.py
LeonarddeR Dec 30, 2024
a3e129a
Update source/brailleDisplayDrivers/brailliantB.py
LeonarddeR Jan 2, 2025
2baa9a9
Update source/brailleDisplayDrivers/eurobraille/driver.py
LeonarddeR Jan 2, 2025
b0283da
Use StrEnum again
LeonarddeR Jan 2, 2025
c176ce6
Fix eurobraille mistakes due to coderabbit suggestions
LeonarddeR Jan 2, 2025
47e6fc5
Add doc string
LeonarddeR Jan 2, 2025
543f783
Undo more unrelated/faulty changes
LeonarddeR Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix eurobraille mistakes due to coderabbit suggestions
  • Loading branch information
@LeonarddeR
LeonarddeR committed Jan 2, 2025
commit c176ce6b0949a16f2e379fe6a2e2103a754f199b
6 changes: 3 additions & 3 deletions source/brailleDisplayDrivers/eurobraille/driver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ def __init__(self, port="Auto"):
port=port,
),
)
if self.deviceType.startswith(("bnote", "bbook")):
if self.deviceType.startswith(("bnote", "bbook")):
# send identifier to bnote / bbook with current COM port
comportNumber = f'{int(re.match(".*?([0-9]+)$", port).group(1)):02d}'
identifier = f"NVDA/{comportNumber}".encode()
Expand All @@ -158,7 +158,7 @@ def __init__(self, port="Auto"):

def terminate(self):
try:
if self.deviceType.startswith(("bnote", "bbook")):
if self.deviceType.startswith(("bnote", "bbook")):
# reset identifier to bnote / bbook with current COM port
self._sendPacket(constants.EB_SYSTEM, constants.EB_CONNECTION_NAME, b"")
super().terminate()
Expand All @@ -173,7 +173,7 @@ def terminate(self):
def _prepFirstByteStreamAndData(
self,
data: bytes,
) -> (bytes, Union[BytesIO, hwIo.IoBase], bytes):
) -> tuple[bytes, Union[BytesIO, hwIo.IoBase], bytes]:
if self.isHid:
# data contains the entire packet.
# HID Packets start with 0x00.
Expand Down