Skip to content

Correct internal gesture ID for Seika Notetaker #17047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seanbudd merged 6 commits into from
Sep 19, 2024
Merged

Correct internal gesture ID for Seika Notetaker #17047

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d312b47
Correct internal gesture ID for Seika Notetaker
school510587 Aug 23, 2024
df5cae0
Merge branch 'master' of https://github.com/nvaccess/nvda into fix_se…
school510587 Sep 12, 2024
bd338c2
Add entries to describe the above merge
school510587 Sep 12, 2024
69134a2
Improve clarity of user changes entry.
SaschaCowley Sep 19, 2024
d05b5da
Merge branch 'master' into fix_seikantk_internal_gesture_name
SaschaCowley Sep 19, 2024
5a433b9
Merge branch 'master' into fix_seikantk_internal_gesture_name
seanbudd Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions source/brailleDisplayDrivers/seikantk.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,13 +308,13 @@ def _handleKeys(self, arg: bytes):
gestures = []
if brailleDots:
if key in (1, 2, 3): # bk:space+dots
gestures.append(InputGesture(dots=brailleDots, space=key))
key = 0
gestures.append(InputGesture(dots=brailleDots, space=True))
else: # bk:dots
gestures.append(InputGesture(dots=brailleDots, space=False))
gestures.append(InputGesture(dots=brailleDots, space=0))
if key:
if key in (1, 2): # bk:space
Comment thread
SaschaCowley marked this conversation as resolved.
gestures.append(InputGesture(dots=0, space=True))
gestures.append(InputGesture(dots=0, space=key))
else: # br(seikantk):XXX
gestures.append(InputGesture(keys=key))
for gesture in gestures:
Expand Down Expand Up @@ -391,7 +391,7 @@ def _getRoutingIndexes(routingKeyBytes: bytes) -> Set[int]:
class InputGesture(braille.BrailleDisplayGesture, brailleInput.BrailleInputGesture):
source = BrailleDisplayDriver.name

def __init__(self, keys=None, dots=None, space=False, routing=None):
def __init__(self, keys=None, dots=None, space=0, routing=None):
super(braille.BrailleDisplayGesture, self).__init__()
# see what thumb keys are pressed:
names = set()
Expand All @@ -400,8 +400,8 @@ def __init__(self, keys=None, dots=None, space=False, routing=None):
elif dots is not None:
self.dots = dots
if space:
self.space = space
names.add(_keyNames[1])
self.space = bool(space)
names.update(_getKeyNames(space, _keyNames))
names.update(_getKeyNames(dots, _dotNames))
elif routing is not None:
self.routingIndex = routing
Expand Down