Skip to content

Give ui.browseableMessage the ability to show copy and close buttons after the message, and add buttons to some instances (2nd try) #17018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seanbudd merged 15 commits into from
Aug 29, 2024
Merged

Give ui.browseableMessage the ability to show copy and close buttons after the message, and add buttons to some instances (2nd try) #17018

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
be5769f
Add Copy and Close buttons to ui.browseableMessage, and a few of its …
Aug 13, 2024
5b76026
Make the _warningBrowseableMessage* functions self-contained with res…
Aug 15, 2024
5b9a898
Pre-commit auto-fix
pre-commit-ci[bot] Aug 18, 2024
b4a462e
Changes
Aug 18, 2024
eacc8c1
New handleKeyPress code in JS, as proposed by the AI.
Aug 19, 2024
f58e85f
AI proposed more modern copy code. AI isn't sure if it will work.
Aug 19, 2024
c071400
Revert "AI proposed more modern copy code. AI wasn't sure if it worke…
Aug 19, 2024
b50e031
AI suggested improvement to error logging detail.
Aug 19, 2024
b41b6ea
Merge branch 'master' into fix14641again
Aug 19, 2024
06f731e
Merge branch 'master' into fix14641again
Aug 22, 2024
2eab076
Fix a bug where copy accelerator still worked, even if button wasn't …
Aug 22, 2024
e1ccda5
Merge branch 'master' into fix14641again
Aug 28, 2024
ce75b54
Changes update
Aug 28, 2024
28baf8c
Update source/ui.py
seanbudd Aug 29, 2024
4dc3c77
Merge branch 'master' into fix14641again
seanbudd Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "AI proposed more modern copy code. AI wasn't sure if it worke… 
…d, and it doesn't.

This reverts commit f58e85f.
  • Loading branch information
Luke Davis, Open Source Systems Luke Davis, Open Source Systems
Luke Davis, Open Source Systems authored and Luke Davis, Open Source Systems committed Aug 19, 2024
commit c071400f97cb22580e9dcc69985da7ac4ee7f905
23 changes: 13 additions & 10 deletions source/message.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,18 +23,21 @@
}
Comment thread
XLTechie marked this conversation as resolved.

function onCopyButtonPress() {
var range = document.createRange();
var selection = window.getSelection();
range.selectNodeContents(messageDiv);
selection.removeAllRanges();
selection.addRange(range);
try {
var success = document.execCommand('copy');
copyStatusDiv.innerHTML = '<p id="copyStatusText" style="font-weight:bold; text-align:center;"></p>';
copyStatusText.innerText = success ? args.item('copySuccessfulAlertText') : args.item('copyFailedAlertText');
} catch (err) {
// Copy code came from http://www.codestore.net/store.nsf/unid/DOMM-4QHQE8/
var rng = document.body.createTextRange();
rng.moveToElementText(messageDiv);
rng.scrollIntoView();
rng.select();
var success = rng.execCommand("Copy");
rng.collapse(false);
rng.select();
copyStatusDiv.innerHTML = '<p id="copyStatusText" style="font-weight:bold; text-align:center;"></p>';
if (success) { // Notify the user about the copy result
copyStatusText.innerText = args.item('copySuccessfulAlertText');
} else {
copyStatusText.innerText = args.item('copyFailedAlertText');
}
// Time out the user alert message
setTimeout(function() {
copyStatusDiv.innerHTML = '';
}, copyStatusTimeout);
Expand Down