Skip to content

Several fixes to native selection mode #16129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seanbudd merged 4 commits into from
Feb 6, 2024
Merged

Several fixes to native selection mode #16129

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
33caf1c
Fix multiple issues with native selection mode in Browse mode, includ…
michaelDCurran Feb 5, 2024
442ee95
Browse mode Toggle native selection script: no need to catch COMError…
michaelDCurran Feb 5, 2024
6a89e65
Update source/browseMode.py
michaelDCurran Feb 5, 2024
9d88619
Update what's new
michaelDCurran Feb 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update source/browseMode.py 
Co-authored-by: Sean Budd <sean@nvaccess.org>
  • Loading branch information
@michaelDCurran @seanbudd
michaelDCurran and seanbudd authored Feb 5, 2024
commit 6a89e65bea8b61369e3c4f9feb28a4b2795c9fa1
2 changes: 1 addition & 1 deletion source/browseMode.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2040,7 +2040,7 @@ def script_toggleNativeAppSelectionMode(self, gesture: inputCore.InputGesture):
# Translators: the message when native selection mode is not available in this browse mode document.
ui.message(_("Native selection mode unsupported in this browse mode document"))
else:
# Translators: the message when native selection mode is not available in this browse mode document.
# Translators: the message when native selection mode cannot be turned off in this browse mode document.
ui.message(_("Native selection mode cannot be turned off in this browse mode document"))
Comment on lines +2040 to +2044

@CyrilleB79 CyrilleB79 Feb 5, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"browse mode document" -> "document"

My feeling is that, for users and translators, there is no need to specify here that the document is a browse mode document (no possible ambiguity). This way, the messages are lighter. Feel free to ignore this suggestion if you disagree with me though.

Suggested change
# Translators: the message when native selection mode is not available in this browse mode document.
ui.message(_("Native selection mode unsupported in this browse mode document"))
else:
# Translators: the message when native selection mode cannot be turned off in this browse mode document.
ui.message(_("Native selection mode cannot be turned off in this browse mode document"))
# Translators: the message when native selection mode is not available in this document.
ui.message(_("Native selection mode unsupported in this document"))
else:
# Translators: the message when native selection mode cannot be turned off in this document.
ui.message(_("Native selection mode cannot be turned off in this document"))

return
nativeAppSelectionModeOn = not self._nativeAppSelectionMode
Expand Down