Skip to content

Use a single APC and completion routine #14924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seanbudd merged 12 commits into from
Jun 2, 2023
Merged

Use a single APC and completion routine #14924

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
39c0df5
Use a single APC and completion routine
May 11, 2023
894fa39
Linting
May 12, 2023
b5f9f42
use proper cast
LeonarddeR May 12, 2023
12e549b
Review actions
LeonarddeR May 15, 2023
813a565
Fixup
LeonarddeR May 15, 2023
f90df1c
Merge remote-tracking branch 'origin/master' into hwIoSingleAPC
LeonarddeR May 19, 2023
41bd560
Import LPOVERLAPPED and OVERLAPPED directly, more documentation about…
LeonarddeR May 19, 2023
a939279
Merge remote-tracking branch 'origin/master' into hwIoSingleAPC
LeonarddeR May 31, 2023
e7a93e2
Readd autoDeleteApcReferences
LeonarddeR May 31, 2023
10ade40
Rename apcsWillBeStronglyReferenced
LeonarddeR Jun 1, 2023
5228a8c
Merge remote-tracking branch 'origin/master' into hwIoSingleAPC
seanbudd Jun 2, 2023
27b655f
update changes
seanbudd Jun 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Readd autoDeleteApcReferences
  • Loading branch information
@LeonarddeR
LeonarddeR committed May 31, 2023
commit e7a93e29a3162b85308346896bdb864d2611b104
11 changes: 11 additions & 0 deletions source/hwIo/ioThread.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,17 @@ def start(self):
super().start()
self.handle = ctypes.windll.kernel32.OpenThread(winKernel.THREAD_SET_CONTEXT, False, self.ident)

if apcsWillBeStronglyReferenced:
Comment thread
seanbudd marked this conversation as resolved.
Outdated
@contextmanager
def autoDeleteApcReference(self, apcUuid):
log.warning(
"IoThread.autoDeleteApcReference is deprecated. "
"It was never meant to be part of the public API. "
"This method will be removed in NVDA 2024.1. "
"Up until that version, it behaves as a no-op, i.e. a context manager yielding nothing."
)
yield

def _registerToCallAsApc(
self,
func: ApcT,
Expand Down