Skip to content

Removed inappropriate pending install item when accessing NVDA menu through systray #14523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seanbudd merged 9 commits into from
Jan 13, 2023
Merged

Removed inappropriate pending install item when accessing NVDA menu through systray #14523

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ba9224d
Removed inappropriate pending install item when accessing NVDA menu t…
CyrilleB79 Jan 9, 2023
e859388
Update source/gui/__init__.py
CyrilleB79 Jan 10, 2023
d84a1c4
Restore gui.MainFrame.evaluateUpdatePendingUpdateMenuItemCommand
CyrilleB79 Jan 11, 2023
b988b17
Empty commit to bump CI again.
CyrilleB79 Jan 11, 2023
ad1f2ad
Update source/gui/__init__.py
CyrilleB79 Jan 12, 2023
a74d33a
Fix lint
CyrilleB79 Jan 12, 2023
fca17c8
Bump CI again.
CyrilleB79 Jan 12, 2023
0267d5d
Merge remote-tracking branch 'origin/master' into noPendingInstall
seanbudd Jan 13, 2023
49ca419
update changes
seanbudd Jan 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update source/gui/__init__.py 
Co-authored-by: Sean Budd <seanbudd123@gmail.com>
  • Loading branch information
@CyrilleB79 @seanbudd
CyrilleB79 and seanbudd authored Jan 12, 2023
commit ad1f2ad4be8a584af6d76db118074fc78eef6d87
6 changes: 6 additions & 0 deletions source/gui/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,13 @@ def onExecuteUpdateCommand(self, evt):
updateCheck.executePendingUpdate()

def evaluateUpdatePendingUpdateMenuItemCommand(self):
log.warning(
"MainFrame.evaluateUpdatePendingUpdateMenuItemCommand is deprecated. "
"Use SysTrayIcon.evaluateUpdatePendingUpdateMenuItemCommand instead.",
stack_info=True,
)
self.sysTrayIcon.evaluateUpdatePendingUpdateMenuItemCommand()
Comment thread
CyrilleB79 marked this conversation as resolved.


@blockAction.when(blockAction.Context.MODAL_DIALOG_OPEN)
def onExitCommand(self, evt):
Expand Down