Skip to content

Add significantly more debug logging to UIAHandler #14256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaelDCurran merged 8 commits into from
Oct 23, 2022
Merged

Add significantly more debug logging to UIAHandler #14256

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0b19104
UIAHandler: move base cacheRequest propertyIDs into their own set at …
michaelDCurran Oct 12, 2022
756a286
UIAHandler: add much greater debug logging to all UIA event handlers.
michaelDCurran Oct 14, 2022
e6e602c
Apply suggestions from code review
michaelDCurran Oct 17, 2022
3ef3703
UIAHandler: linting
michaelDCurran Oct 17, 2022
b45c545
Merge branch 'master' into UIADebugging
michaelDCurran Oct 20, 2022
08c2e94
UIAHandler: any f-strings that don't contain any templating are now s…
michaelDCurran Oct 20, 2022
d959bf0
UIAHandler: make sure to pass isDebug argument to _isUIAWindowHelper …
michaelDCurran Oct 20, 2022
8c74ab4
Update what's new
michaelDCurran Oct 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
UIAHandler: move base cacheRequest propertyIDs into their own set at … 
…global level.
  • Loading branch information
@michaelDCurran
michaelDCurran committed Oct 16, 2022
commit 0b19104e79789ec723b3b10b7e9fbcc18a6b55de
11 changes: 10 additions & 1 deletion source/UIAHandler/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,14 @@
from . import remote as UIARemote


baseCachePropertyIDs = set([
Comment thread
michaelDCurran marked this conversation as resolved.
Outdated
UIA.UIA_FrameworkIdPropertyId, UIA.UIA_AutomationIdPropertyId, UIA.UIA_ClassNamePropertyId,
Comment thread
seanbudd marked this conversation as resolved.
Outdated
UIA.UIA_ControlTypePropertyId, UIA.UIA_ProviderDescriptionPropertyId, UIA.UIA_ProcessIdPropertyId,
UIA.UIA_IsTextPatternAvailablePropertyId,
UIA.UIA_IsContentElementPropertyId, UIA.UIA_IsControlElementPropertyId,
UIA.UIA_NamePropertyId, UIA.UIA_LocalizedControlTypePropertyId,
])

#: The window class name for Microsoft Word documents.
# Microsoft Word's UI Automation implementation
# also exposes this value as the document UIA element's classname property.
Expand Down Expand Up @@ -366,7 +374,7 @@ def MTAThreadFunc(self):
self.UIAWindowHandleCache={}
self.baseTreeWalker=self.clientObject.RawViewWalker
self.baseCacheRequest=self.windowCacheRequest.Clone()
for propertyId in (UIA_FrameworkIdPropertyId,UIA_AutomationIdPropertyId,UIA_ClassNamePropertyId,UIA_ControlTypePropertyId,UIA_ProviderDescriptionPropertyId,UIA_ProcessIdPropertyId,UIA_IsTextPatternAvailablePropertyId,UIA_IsContentElementPropertyId,UIA_IsControlElementPropertyId):
for propertyId in baseCachePropertyIDs:
self.baseCacheRequest.addProperty(propertyId)
self.baseCacheRequest.addPattern(UIA_TextPatternId)
self.rootElement=self.clientObject.getRootElementBuildCache(self.baseCacheRequest)
Expand Down Expand Up @@ -651,6 +659,7 @@ def IUIAutomationFocusChangedEventHandler_HandleFocusChangedEvent(self,sender):
if _isDebug():
log.debug("HandleFocusChangedEvent: Ignoring for non native element")
return
log.info(f"UIA focus: {sender.currentName} {sender.currentLocalizedControlType}")
import NVDAObjects.UIA
if isinstance(eventHandler.lastQueuedFocusObject,NVDAObjects.UIA.UIA):
lastFocusObj = eventHandler.lastQueuedFocusObject
Expand Down