Skip to content

Disable UIA text change events outside of Word, Windows Console, and Windows Terminal #14067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seanbudd merged 8 commits into from
Aug 29, 2022
Merged

Disable UIA text change events outside of Word, Windows Console, and Windows Terminal #14067

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
67e3ad9
Disable UIA text change events outside Windows Console and Terminal
codeofdusk Aug 25, 2022
6bf9745
update changes
seanbudd Aug 26, 2022
7551a45
Fix Windows Conhost
codeofdusk Aug 27, 2022
f73cb1c
Improve logging
codeofdusk Aug 27, 2022
642c37b
Fix global event registration
codeofdusk Aug 27, 2022
ed255c1
Add comment
codeofdusk Aug 27, 2022
c12770c
Update source/UIAHandler/__init__.py
codeofdusk Aug 29, 2022
35e3640
Style
codeofdusk Aug 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix Windows Conhost
  • Loading branch information
@codeofdusk
codeofdusk committed Aug 27, 2022
commit 7551a459faaab342b3a1c68fdcc2d770147dc4f3
13 changes: 10 additions & 3 deletions source/UIAHandler/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,9 +99,12 @@
"Shell_SystemDialog", # Various dialogs in Windows 10 Settings app
]

textChangeUIAAutomationIDs = (
"Text Area", # Windows Console Host
)

textChangeUIAClassNames = (
"_WwG",
"ConsoleWindowClass",
"_WwG", # Microsoft Word
"TermControl",
"TermControl2"
)
Expand Down Expand Up @@ -494,6 +497,7 @@ def func():
group = (
self.localEventHandlerGroupWithTextChanges
if element.currentClassName in textChangeUIAClassNames
or element.CachedAutomationID in textChangeUIAAutomationIDs
else self.localEventHandlerGroup
)
self.addEventHandlerGroup(element, group)
Expand Down Expand Up @@ -531,7 +535,10 @@ def IUIAutomationEventHandler_HandleAutomationEvent(self,sender,eventID):
log.debug("HandleAutomationEvent: Ignored MenuOpenedEvent while focus event pending")
return
if eventID == UIA.UIA_Text_TextChangedEventId:
if sender.currentClassName in textChangeUIAClassNames:
if (
sender.currentClassName in textChangeUIAClassNames
or sender.CachedAutomationID in textChangeUIAAutomationIDs
):
NVDAEventName = "textChange"
else:
if _isDebug():
Expand Down