Skip to content

Prototype for Windows Terminal: Use notifications instead of monitoring for new text #14047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seanbudd merged 27 commits into from
Oct 25, 2022
Merged

Prototype for Windows Terminal: Use notifications instead of monitoring for new text #14047

Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
c5a4a8c
Prototype for Windows Terminal: Use notifications instead of monitori…
LeonarddeR Aug 22, 2022
60d4b36
Comments
LeonarddeR Aug 22, 2022
5054d0c
Apply suggestions from code review
LeonarddeR Aug 24, 2022
f9771b3
Fix imports
LeonarddeR Aug 24, 2022
2cafc67
Import ordering
LeonarddeR Aug 24, 2022
f39870b
Merge branch 'master' into wtNotifications
codeofdusk Aug 29, 2022
1176505
Remove Windows Terminal from textChangeUIAClassNames as it no longer …
codeofdusk Aug 29, 2022
9735811
Suppress more blanks
codeofdusk Aug 29, 2022
3b678c4
Merge branch 'master' into wtNotifications
codeofdusk Sep 20, 2022
f79d0f6
Merge branch 'master' into wtNotifications
codeofdusk Sep 29, 2022
a2bff15
Merge branch 'master' into wtNotifications
codeofdusk Oct 18, 2022
40ca1e0
Place new functionality behind a feature flag
codeofdusk Oct 18, 2022
73b5367
Remove dead code
codeofdusk Oct 18, 2022
497e3f3
Rename flag enum
codeofdusk Oct 20, 2022
2cba013
Apply suggestions from code review
codeofdusk Oct 20, 2022
69f621e
Rename _shouldUseWtNotifications to _shouldUseWindowsTerminalNotifica…
codeofdusk Oct 20, 2022
81fe5e0
Apply suggestions from code review
codeofdusk Oct 21, 2022
6a1bbb2
Style
codeofdusk Oct 21, 2022
e043da9
Add types
codeofdusk Oct 24, 2022
b6620a7
Fix hyphen
codeofdusk Oct 24, 2022
f992db5
Add alias
codeofdusk Oct 24, 2022
1b915a0
Use getattr
codeofdusk Oct 24, 2022
715168b
Update source/NVDAObjects/UIA/winConsoleUIA.py
codeofdusk Oct 24, 2022
5139a56
Rename
codeofdusk Oct 24, 2022
b706a19
Merge branch 'wtNotifications' of https://github.com/leonardder/nvda …
codeofdusk Oct 24, 2022
5fe8559
Merge remote-tracking branch 'origin/master' into wtNotifications
seanbudd Oct 25, 2022
f6f6563
update changes
seanbudd Oct 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Bill Dengler <codeofdusk@gmail.com>
  • Loading branch information
@LeonarddeR @codeofdusk
LeonarddeR and codeofdusk committed Aug 25, 2022
commit 5054d0c4678dff6f32c0052d9a18e1553f26c7fd
14 changes: 12 additions & 2 deletions source/NVDAObjects/UIA/winConsoleUIA.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
from UIAHandler.utils import _getConhostAPILevel
from UIAHandler.constants import WinConsoleAPILevel
from . import UIA, UIATextInfo
from ..behaviors import EnhancedTermTypedCharSupport, KeyboardHandlerBasedTypedCharSupport
from ..behaviors import KeyboardHandlerBasedTypedCharSupport
from ..window import Window


Expand Down Expand Up @@ -427,4 +427,14 @@ class WinTerminalUIA(UIA):
announceNewLineText=False

def event_UIA_notification(self, notificationKind, notificationProcessing, displayString, activityId):
Comment thread
LeonarddeR marked this conversation as resolved.
Outdated

@seanbudd seanbudd Oct 20, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this function header get typing information added?

@codeofdusk codeofdusk Oct 20, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no typing on this method signature in the superclass either.

@seanbudd seanbudd Oct 23, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add types where they are known/obvious/simple?
This is still introducing new code without typing.

speech.speakText(displayString)
# Do not announce output from background terminals.
if self.appModule != api.getFocusObject().appModule:
return
# microsoft/terminal#12358: Automatic reading of terminal output
# is provided by UIA notifications. If the user does not want
# automatic reporting of dynamic output, suppress this notification.
if not config.conf["presentation"]["reportDynamicContentChanges"]:
return
for line in displayString.splitlines():
if line: # Don't say "blank" during autoread
speech.speakText(line)