Skip to content

Send architecture when update checking #14019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seanbudd merged 5 commits into from
Aug 19, 2022
Merged

Send architecture when update checking #14019

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3f72b64
Send architecture when update checking
LeonarddeR Aug 16, 2022
f8b1298
Update source/updateCheck.py
seanbudd Aug 17, 2022
6628608
add comment to x64 tracking
seanbudd Aug 19, 2022
d610940
Merge branch 'master' into environment
seanbudd Aug 19, 2022
08efa1c
update changes
seanbudd Aug 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions source/updateCheck.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,11 @@ def checkForUpdate(auto: bool = False) -> Optional[Dict]:
"version": versionInfo.version,
"versionType": versionInfo.updateVersionType,
"osVersion": winVersionText,
# Check if the architecture is the most common: "AMD64"
# Available values of PROCESSOR_ARCHITEW6432 found in:
# https://docs.microsoft.com/en-gb/windows/win32/winprog64/wow64-implementation-details
"x64": os.environ.get("PROCESSOR_ARCHITEW6432") == "AMD64",
"osArchitecture": os.environ.get("PROCESSOR_ARCHITEW6432"),

@seanbudd seanbudd Aug 16, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change will require server side changes (to be recorded)

@seanbudd seanbudd Aug 16, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be safe to merge as-is, with changes to the server implemented later

@seanbudd seanbudd Aug 17, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's worth raising that this is additional user tracking.

I don't think it is a big leap from tracking x64 vs x86.
The only difference is tracking which x64-bit architecture is in use, out of (AMD64, ARM64, IA64).
One potential negative - considering ARM64 and IA64 are more unusual, getting a thumbprint of a user based on their update check might become easier in theory.

}
if auto and allowUsageStats:
synthDriverClass = synthDriverHandler.getSynth().__class__
Expand Down