Skip to content

Restore VS2022 support #13524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaelDCurran merged 7 commits into from
Mar 24, 2022
Merged

Restore VS2022 support #13524

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
bcd6230
UIA Remote operations library back to upstream
LeonarddeR Mar 22, 2022
fe0bec4
Support building with VS2022 again
LeonarddeR Mar 23, 2022
31aa5eb
Override platform toolset to always use the toolset detected by scons
LeonarddeR Mar 23, 2022
bacce2f
Make a note in the readme about toolset
LeonarddeR Mar 23, 2022
83b4a51
Review actions
LeonarddeR Mar 24, 2022
2e88d21
Merge branch 'master' into uiaUpstream
michaelDCurran Mar 24, 2022
11924f0
Update what's new
michaelDCurran Mar 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make a note in the readme about toolset 
This reverts commit 31aa5eb.
  • Loading branch information
@LeonarddeR
LeonarddeR committed Mar 23, 2022
commit bacce2fd23fb21d57a0eef13fcc1ebd6f0ddecd1
13 changes: 3 additions & 10 deletions nvdaHelper/microsoft-ui-uiautomation/sconscript
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ MSUIA_sourceDir = Dir('#include/microsoft-ui-uiautomation/src/uiAutomation')
MSUIA_lib_outDir = Dir('lib')
MSUIA_include_outDir = Dir('include')
MSUIA_solutionFile = MSUIA_sourceDir.File('UIAutomation.sln')
msvc = env.get('MSVC_VERSION').replace(".", "")

MSUIA_wrapper_libs = env.Command(
>
Expand All @@ -67,14 +66,11 @@ MSUIA_wrapper_libs = env.Command(
],
action = [
# Fetch any required NuGet packages
f"msbuild /nologo {MSUIA_solutionFile} /t:Restore /p:RestorePackagesConfig=true,Configuration=Release,Platform=x86",
f"msbuild {MSUIA_solutionFile} /t:Restore /p:RestorePackagesConfig=true,Configuration=Release,Platform=x86",
# Remove any old generated files
Delete(MSUIA_sourceDir.Dir('microsoft.ui.uiautomation/Generated Files')),
# Do the actual build
"msbuild /nologo /t:Build /p:Configuration=Release,Platform=x86,PlatformToolset=v{msvc},OutDir={outDir}/ $SOURCE".format(
msvc=msvc,
outDir=MSUIA_lib_outDir.abspath
)
"msbuild /t:Build /p:Configuration=Release,Platform=x86,OutDir={outDir}/ $SOURCE".format(outDir=MSUIA_lib_outDir.abspath)
],
)
env.Ignore(MSUIA_wrapper_libs,MSUIA_sourceDir.File('microsoft.ui.uiautomation/Microsoft.UI.UIAutomation_h.h'))
Expand All @@ -92,10 +88,7 @@ MSUIA_abstraction_libs = env.Command(
glob.glob(os.path.join(MSUIA_sourceDir.abspath, 'UiaOperationAbstraction', '*.h')),
],
action = [
"msbuild /nologo /t:Build /p:Configuration=Release,Platform=x86,PlatformToolset=v{msvc},OutDir={outDir}/ $SOURCE".format(
msvc=msvc,
outDir=MSUIA_lib_outDir.abspath
),
"msbuild /t:Build /p:Configuration=Release,Platform=x86,OutDir={outDir}/ $SOURCE".format(outDir=MSUIA_lib_outDir.abspath),
]
)

Expand Down
1 change: 1 addition & 0 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ The following dependencies need to be installed on your system:
* When you are intending to use the Visual Studio IDE (not required for NVDA development), you can download [the community version](https://aka.ms/vs/16/release/vs_Community.exe), which is also used by appveyor
* The Professional and Enterprise versions are also supported
* Preview versions are *not* supported
* Building with Visual Studio 2022 explicitly requires the MSVC v142 - VS 2019 C++ build tools to be installed (see below)
* When installing Visual Studio, you need to enable the following:
* In the list on the Workloads tab
* in the Windows grouping:
Expand Down