Skip to content

Fix Excel error due to state enum changes #13465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feerrenrut merged 4 commits into from
Mar 14, 2022
Merged

Fix Excel error due to state enum changes #13465

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5d6d1f8
Make cell state values specific to Excel implementation
feerrenrut Mar 11, 2022
f5fa22d
add unit test to ensure mapping covers all cellstates
feerrenrut Mar 11, 2022
b295577
updates changes file for #13465
feerrenrut Mar 14, 2022
f286875
add comment to note python enum values match c++ enum values
feerrenrut Mar 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
updates changes file for #13465
  • Loading branch information
@feerrenrut
feerrenrut committed Mar 14, 2022
commit b29557752e6ced178be2d75cb84a251ee831edb2
2 changes: 2 additions & 0 deletions user_docs/en/changes.t2t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,8 @@ This can dramatically decrease build times on multi core systems. (#13226, #1337
- ``UIAHandler.UIAControlTypesToNVDARoles``
-
-
- Excel cell state constants (``NVSTATE_*``) are now values in the ``NvCellState`` enum, mirrored in the ``NvCellState`` enum in ``NVDAObjects/window/excel.py`` and mapped to ``controlTypes.State`` via _nvCellStatesToStates. (#13465)
- ``EXCEL_CELLINFO`` struct member ``state`` is now ``nvCellStates``.
-


Expand Down