Repository navigation
Prevent crash when selecting papenmeier braille display driver, remove brxcom wrapper #13348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
seanbudd
merged 9 commits into
nvaccess:master
from
Stefan-Kliesch-FHP:Stefan-Kliesch-FHP-BrxCom-Removed
Mar 7, 2022
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
9bcb6de
Add files via upload
Stefan-Kliesch-FHP 8943bd9
Update userGuide.t2t
Stefan-Kliesch-FHP 871daa2
Update userGuide.t2t
Stefan-Kliesch-FHP efae903
Update userGuide.t2t
Stefan-Kliesch-FHP 519062f
Update source/brailleDisplayDrivers/papenmeier.py
Stefan-Kliesch-FHP 656246c
Update userGuide.t2t
Stefan-Kliesch-FHP efc9232
Add files via upload
Stefan-Kliesch-FHP 463e76b
Merge remote-tracking branch 'origin/master' into Stefan-Kliesch-FHP-…
seanbudd 44f5e3d
update changes
seanbudd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update userGuide.t2t
restored file
- Loading branch information
commit efae9038515d729cdddc31b7459255b324468534
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please reintroduce this line - there should be no changes to the German documentation in this PR as it would introduce conflicts for translators.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it fine now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm afraid it isn't. This should be just empty line not hyphen. Essentially when looking at the list of files modified by this PR German user guide should not be mentioned at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I restored it from nvaccess:master and it's gone from the "files changed" list!