Skip to content

Improve selection and merged cell announcements in LibreOffice Calc 7.3 and above #12849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seanbudd merged 11 commits into from
Oct 20, 2021
Merged

Improve selection and merged cell announcements in LibreOffice Calc 7.3 and above #12849

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b9f7ee1
Improve selection and merged cell announcement in LibreOffice Calc
LeonarddeR Sep 13, 2021
f534f2d
Fix typo
LeonarddeR Sep 16, 2021
cedd3f0
Merge remote-tracking branch 'origin/master' into soffice
LeonarddeR Sep 16, 2021
e135386
Lint fix
LeonarddeR Sep 16, 2021
efad4d4
Import IA2 from IAccessibleHandler
LeonarddeR Sep 16, 2021
2db3707
DEMO: reset IEnumVARIANT object before using it to retrieve child count
michaelweghorn Sep 17, 2021
5fa7c01
Clarification
LeonarddeR Sep 18, 2021
8da36f6
Merge remote-tracking branch 'origin/master' into soffice
LeonarddeR Sep 23, 2021
78c4402
Apply suggestions from code review
LeonarddeR Sep 27, 2021
bfe8453
Merge remote-tracking branch 'origin/master' into soffice
seanbudd Oct 19, 2021
d116976
update changes
seanbudd Oct 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
DEMO: reset IEnumVARIANT object before using it to retrieve child count 
s. discussion in
#9310
  • Loading branch information
@michaelweghorn @LeonarddeR
michaelweghorn authored and LeonarddeR committed Sep 18, 2021
commit 2db3707fd05e5f7971cf44675e6fd2c36416a0c6
1 change: 1 addition & 0 deletions source/NVDAObjects/IAccessible/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1303,6 +1303,7 @@ def _getSelectedItemsCount_accSelection(self, maxCount):
# Call the rawmethod for IEnumVARIANT::Next as COMTypes' overloaded version does not allow limiting the amount of items returned
numItemsFetched=ctypes.c_ulong()
itemsBuf=(VARIANT*(maxCount+1))()
enumObj.Reset()
res=enumObj._IEnumVARIANT__com_Next(maxCount,itemsBuf,ctypes.byref(numItemsFetched))
# IEnumVARIANT returns S_FALSE if the buffer is too small, although it still writes as many as it can.
# For our purposes, we can treat both S_OK and S_FALSE as success.
Expand Down
4 changes: 0 additions & 4 deletions source/appModules/soffice.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,10 +240,6 @@ def _get_cellCoordsText(self):

class SymphonyTable(IAccessible):

def _getSelectedItemsCount_accSelection(self, maxCount):
# accSelection is broken in LibreOffice.
raise NotImplementedError

def event_selectionWithIn(self):
curFocus = api.getFocusObject()
if self == curFocus.table:
Expand Down