Skip to content

Refactor COM Registration Fixing Tool part 2: remove bugs, return Windows errors, improve UX #12355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SaschaCowley merged 71 commits into from
Sep 20, 2024
Merged

Refactor COM Registration Fixing Tool part 2: remove bugs, return Windows errors, improve UX #12355

Changes from 1 commit
Commits
Show all changes
71 commits
Select commit Hold shift + click to select a range
45345c7
Refactored the COM Registration Fixing Tool to fix bugs and impro…
Sep 2, 2024
239810d
changes
Sep 2, 2024
5467ff6
Pre-commit auto-fix
pre-commit-ci[bot] Sep 2, 2024
a293607
String reformatting
Sep 3, 2024
5dfea2a
Remove old imports
Sep 3, 2024
e15dedc
Emitintro message using a method.
Sep 3, 2024
e948d0f
Fix quoting
Sep 3, 2024
9dec84d
Pre-commit auto-fix
pre-commit-ci[bot] Sep 3, 2024
9c25ec8
Line length fixes.
Sep 3, 2024
07e172f
Fix bad perms.
Sep 3, 2024
842ca05
Trying new continue/cancel dialog
Sep 3, 2024
2282ece
Fix various things the AI did wrong.
Sep 3, 2024
1895c6d
Remove warning icon and ding.
Sep 3, 2024
c37844e
Pre-commit auto-fix
pre-commit-ci[bot] Sep 3, 2024
16cc4e2
Fix title and message ordering in ContinueCancelDialog.__init__
Sep 3, 2024
60d6a4f
Remove unnecessary UTF-8 header line
Sep 3, 2024
2edf3c7
Fix instruction from "Press OK" to "Press Continue".
Sep 3, 2024
d180df6
Add docstring.
Sep 3, 2024
661af13
Fix-up some indenting.
Sep 3, 2024
c655cc5
Pre-commit auto-fix
pre-commit-ci[bot] Sep 3, 2024
2cf4977
Merge branch 'master' into CRFTRefactor
Sep 3, 2024
f38b55f
Added a note to changes for devs.
Sep 3, 2024
a8d871c
Merge branch 'master' into CRFTRefactor
Sep 5, 2024
b497007
Implemented an alternate way of having the Cancel button be selected …
Sep 5, 2024
0bc63ce
Pre-commit auto-fix
pre-commit-ci[bot] Sep 5, 2024
7465eb2
Apply Sean's proposed language to replace the "...power user..." refe…
XLTechie Sep 6, 2024
1f2f510
Merge branch 'master' into CRFTRefactor
Sep 6, 2024
020bfbf
One more try at NVDA style method definition indenting.
Sep 6, 2024
8cb3c21
Pre-commit auto-fix
pre-commit-ci[bot] Sep 6, 2024
4ccae98
Apply suggestions from code review
XLTechie Sep 9, 2024
28b202d
Merge branch 'master' into CRFTRefactor
Sep 9, 2024
255106d
Move new class to nvdaControls.py
Sep 9, 2024
d46fe7d
Transformed the intro message from a method to a constant.
Sep 9, 2024
5597e09
Fix bad import.
Sep 10, 2024
82b6cc5
Merge branch 'master' into CRFTRefactor
Sep 10, 2024
4fda926
Apply suggestions from code review
XLTechie Sep 10, 2024
70e2f61
Make ContinueCancelDialog private. Type hint ButtonHelper instances m…
Sep 10, 2024
a7712bc
Make message and class private in init.
Sep 10, 2024
e6bb3bf
Fix missed change
Sep 10, 2024
9c81960
Merge branch 'master' into CRFTRefactor
Sep 10, 2024
7f1ee11
Rebuild
Sep 10, 2024
c81163c
Edit user guide
Sep 10, 2024
72baafe
Merge branch 'master' into CRFTRefactor
Sep 16, 2024
2a4b537
String update.
Sep 16, 2024
479bf4f
Review suggestions for user guide
Sep 16, 2024
e225029
Attempt context help
Sep 16, 2024
fe7577f
Pre-commit auto-fix
pre-commit-ci[bot] Sep 16, 2024
037bc61
Fix import
Sep 16, 2024
d9ce718
Pre-commit auto-fix
pre-commit-ci[bot] Sep 16, 2024
107f27e
Merge branch 'master' into CRFTRefactor
Sep 17, 2024
66cf13a
Docstring update for context help
Sep 17, 2024
3e399f5
One more update of the message.
Sep 17, 2024
fa1e81f
Update the message again, per review request.
Sep 17, 2024
f76faf8
Syntax fixes
SaschaCowley Sep 17, 2024
97a472d
Apply newline suggestions from code review
XLTechie Sep 18, 2024
4eb0fd0
Very minor grammar enhancement.
Sep 18, 2024
c9c59f3
Merge branch 'master' into CRFTRefactor
Sep 18, 2024
ef7f345
Correction to an unrelated changes listing
Sep 18, 2024
7be360a
Slight grammar clarification in user guide.
XLTechie Sep 18, 2024
70b596c
Correction to grammar clarification in user guide.
XLTechie Sep 18, 2024
5fd2344
Remove attribution from changes entries
Sep 19, 2024
4e88743
Merge branch 'master' into CRFTRefactor
Sep 19, 2024
10ea475
Apply suggestions from code review
XLTechie Sep 19, 2024
78a1398
Update user guide per review suggestion.
Sep 19, 2024
1a158f1
Add a clarifying comment
Sep 19, 2024
aba1ce7
Change a word in the intro message for more clarity.
XLTechie Sep 19, 2024
bad035a
Merge branch 'master' into CRFTRefactor
Sep 19, 2024
5bcf510
Revert "Update user guide per review suggestion.": a newer version ma…
Sep 19, 2024
894e820
Merge branch 'master' into CRFTRefactor
Sep 19, 2024
1e58fae
Potential new user guide entry.
Sep 19, 2024
f8befd5
Fix a tiny bit of structure in the UG
Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove old imports
  • Loading branch information
Luke Davis Luke Davis
Luke Davis authored and Luke Davis committed Sep 3, 2024
commit 5dfea2a734e81c3ff61ceff9c447fb0b38d3baef
3 changes: 0 additions & 3 deletions source/gui/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,7 @@
# messageBox is accessed through `gui.messageBox` as opposed to `gui.message.messageBox` throughout NVDA,
# be cautious when removing
messageBox,
displayDialogAsModal,
)
from .nvdaControls import MessageDialog
from . import blockAction
from .speechDict import (
DefaultDictionaryDialog,
Expand Down Expand Up @@ -70,7 +68,6 @@
import speechViewer
import winUser
import api
import gui.contextHelp as contextHelp
import NVDAState


Expand Down