Skip to content

Add missing formatting information in MS Excel cells (strikethrough, superscript/subscript) #12264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seanbudd merged 4 commits into from
Apr 20, 2021
Merged

Add missing formatting information in MS Excel cells (strikethrough, superscript/subscript) #12264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d146564
Add missing formatting information in MS Excel cells (strikethrough, …
CyrilleB79 Apr 1, 2021
5278fc2
Merge branch 'master' into excelFormatting
seanbudd Apr 20, 2021
1de7593
Merge branch 'master' into excelFormatting
seanbudd Apr 20, 2021
b1a5026
update changes
seanbudd Apr 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion source/NVDAObjects/window/excel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -994,6 +994,12 @@ def _getFormatFieldAndOffsets(self,offset,formatConfig,calculateOffsets=True):
formatField['italic']=fontObj.italic
underline=fontObj.underline
formatField['underline']=False if underline is None or underline==xlUnderlineStyleNone else True
formatField['strikethrough'] = fontObj.strikethrough
if formatConfig['reportSuperscriptsAndSubscripts']:
if fontObj.superscript:
formatField['text-position'] = 'super'
elif fontObj.subscript:
formatField['text-position'] = 'sub'
if formatConfig['reportStyle']:
try:
styleName=self.obj.excelCellObject.style.nameLocal
Expand Down Expand Up @@ -1471,7 +1477,7 @@ def reportFocus(self):
formatField.update(field.field)
if not hasattr(self.parent,'_formatFieldSpeechCache'):
self.parent._formatFieldSpeechCache = textInfos.Field()
if formatField:
if formatField or self.parent._formatFieldSpeechCache:
sequence = speech.getFormatFieldSpeech(
formatField,
attrsCache=self.parent._formatFieldSpeechCache,
Expand Down
1 change: 1 addition & 0 deletions user_docs/en/changes.t2t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ What's New in NVDA
- It is once again possible to use NVDA in a languages containing underscores in the locale name such as de_CH on Windows 10 1803 and 1809. (#12250)
- In WordPad, configuration of superscript/subscript reporting works as expected. (#12262)
- NVDA no longer fails to announce the newly focused content on a web page if the old focus disappears and is replaced by the new focus in the same position. (#12147)
- Strikethrough, superscript and subscript formatting for entire Excel cells are now reported if the corresponding option is enabled. (#12264)


== Changes for Developers ==
Expand Down