Skip to content

Introduce winVersion.WinVersion class to record Windows version information, removing winVersion.isWin10 function #11909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feerrenrut merged 57 commits into from
Mar 25, 2021
Merged

Introduce winVersion.WinVersion class to record Windows version information, removing winVersion.isWin10 function #11909

Changes from 1 commit
Commits
Show all changes
57 commits
Select commit Hold shift + click to select a range
120d7d4
WinVersion: update copyright header, add Bill Dengler as author
josephsl Dec 2, 2020
a00e1b4
WinVersion: introduce WinVersion class. Re #11837.
josephsl Dec 2, 2020
c3db97c
WinVersion: introduce winVersion.getWinVer function. Re #11837.
josephsl Dec 2, 2020
56c8a1a
WinVersion: introduce winVersion.getWinVerFromVersionText function. R…
josephsl Dec 2, 2020
298dd3a
Merge branch 'master' into WinVersionClass
josephsl Dec 7, 2020
e746b02
winVersion.WinVersion: add unit test cases. Re #11837.
josephsl Dec 7, 2020
9194536
winVersion unittests: lint and additional test on operators (specific…
josephsl Dec 7, 2020
7f60f80
winVersion: convert Windows 10 releases to build map into str:int dic…
josephsl Dec 7, 2020
62f6273
winVersion.WinVersion: transfer isWin10 function to WinVersion class.…
josephsl Dec 7, 2020
4826b54
winVersion.isWin10: deprecated, call winVersion.getWinVer().isWin10 i…
josephsl Dec 7, 2020
52c8841
winVersion unittest: test winVersion.WinVersion.isWin10. Re #11837.
josephsl Dec 7, 2020
3107312
winVersion unittest: lint
josephsl Dec 7, 2020
3bd9ba2
winVersion unittest: fix spelling error in comment
josephsl Dec 7, 2020
c3d41f9
winVersion unittests/operator check: test with 'Windows 8' instead of…
josephsl Dec 8, 2020
5ee0dec
Merge branch 'master' into WinVersionClass
josephsl Dec 11, 2020
a917764
winVersion: add module header/description.
josephsl Dec 11, 2020
e2bd2f0
winVersion: record Windows releases to WinVersion instance mappings. …
josephsl Dec 11, 2020
45e33e9
winVersion.getWinVer: call sys.getwindowsversion function inside getW…
josephsl Dec 11, 2020
989d741
winVersion: compare getWinVer with release constants when checking fo…
josephsl Dec 11, 2020
5be0182
Replace winVersion.isWin10 function call with constant checks. Re #11…
josephsl Dec 11, 2020
ee93632
winVersion: remove isWin10 function and test suite for it. Re #11837.
josephsl Dec 11, 2020
1149105
winVersion.WinVersion class: simplify class constructor. Re #11837.
josephsl Dec 12, 2020
b207ef5
winVersion: rename Windows 10 version map to 'release name to builds'…
josephsl Dec 12, 2020
a1dd33d
winVersion.WinVersion class: add two static methods to return WinVers…
josephsl Dec 12, 2020
79db425
winVersion.WinVersion: add repr method. Re #11837.
josephsl Dec 12, 2020
e9d4a10
winVersion unit tests: test WinVersion.fromReleaseName functions.
josephsl Dec 12, 2020
0d44de2
Remove winVersion.winVersion call. Re #11933.
josephsl Dec 12, 2020
ba3ef2f
Update check: transfer winVersion.winversionText construction routine…
josephsl Dec 12, 2020
b23e44d
winVersion.WinVersion: put version major.minor.build inside parentehs…
josephsl Dec 12, 2020
187e8c7
Startup: report winVersion.getWinVer function output for Windows vers…
josephsl Dec 12, 2020
8e681a8
winVersion: remove winVersion.winVersion/winVersionText. Re #11837.
josephsl Dec 12, 2020
117b6b8
winVersion.WinVersion: say 'Windows 10 prerelease' for builds not inc…
josephsl Dec 12, 2020
b76ff33
winVersion.WinVersion: do not include product type string if not defi…
josephsl Dec 12, 2020
4cbcbdf
Merge branch 'master' into WinVersionClass
josephsl Dec 30, 2020
b3102b2
Update copyright year
josephsl Dec 30, 2020
dd5a55a
winVersion/Windows release: shorten unknown Windows release error mes…
josephsl Dec 30, 2020
f2798a8
Merged master, temporarily use master version of NVDAObjects/IAccessi…
josephsl Jan 3, 2021
eb9820e
winVersion: general lint (E302, E305)
josephsl Jan 3, 2021
6683cae
winVersion: remove unused winUser module import
josephsl Jan 3, 2021
83f1da5
NVDAObjects/IAccessible/winConsole: restore getWinVer/WIN10_1607 afte…
josephsl Jan 3, 2021
1996143
Merge branch 'master' into WinVersionClass
josephsl Jan 14, 2021
cea3d97
Modern keyboard: typo.
josephsl Jan 14, 2021
4398293
WinVersion: remove 'canRunVc2010Builds' function as it is no longer u…
josephsl Jan 14, 2021
2f40832
Modern keyboard: lint and update copyright header
josephsl Jan 14, 2021
46256fa
Merge branch 'master' into WinVersionClass
josephsl Jan 27, 2021
74a0e4a
Merge branch 'master' into WinVersionClass
josephsl Feb 5, 2021
81a1046
Edge Sp[artan (classic Edge): pre-gap removal = build < 15048. Re #11795
josephsl Feb 5, 2021
0888963
Modern keyboard/emoji panel: define variables to hold classi emoji pa…
josephsl Feb 5, 2021
e320820
WinVersion: remove fromReleaseName and fromVersionText static methods…
josephsl Feb 5, 2021
55d6231
WinVersion tests: remove tests that relied on removed static methods,…
josephsl Feb 5, 2021
66e1d5e
Merge branch 'master' into WinVersionClass
josephsl Mar 11, 2021
c3e7ae5
Merge branch 'master' into WinVersionClass
josephsl Mar 16, 2021
bcea799
Merge branch 'master' into WinVersionClass
josephsl Mar 25, 2021
abf4a04
Modern keyboard and unit tests: update copyright header
josephsl Mar 25, 2021
d9c2d52
Modern keyboard/emoji panel: use comparisons rather than builds list.
josephsl Mar 25, 2021
6df58da
Unit tests: add comment on Flake8 F841.
josephsl Mar 25, 2021
7a5073f
Update changes file for PR #11909
feerrenrut Mar 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
winVersion unittest: fix spelling error in comment
  • Loading branch information
@josephsl
josephsl committed Dec 7, 2020
commit 3bd9ba2a4fce61c69a0646a89bc802f8ba75adba
2 changes: 1 addition & 1 deletion tests/unit/test_winVersion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def test_getWinVerFromVersionText(self):
)

def test_moreRecentWinVer(self):
# Specificlaly to test operators.
# Specifically to test operators.
minimumWinVer = winVersion.WinVersion(
major=6,
minor=1,
Expand Down